Don't parse colors for <canvas> in quirks mode

Source/core/html/canvas/CanvasStyle.cpp

 /*
  * Copyright (C) 2006, 2008 Apple Inc. All rights reserved.
  * Copyright (C) 2008, 2010 Nokia Corporation and/or its subsidiary(-ies)
  * Copyright (C) 2007 Alp Toker <alp@atoker.com>
  * Copyright (C) 2008 Eric Seidel <eric@webkit.org>
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
@@ skipping 28 matching lines @@
 #include "wtf/PassRefPtr.h"
 
 namespace WebCore {
 
 enum ColorParseResult { ParsedRGBA, ParsedCurrentColor, ParsedSystemColor, ParseFailed };
 
 static ColorParseResult parseColor(RGBA32& parsedColor, const String& colorString)
 {
     if (equalIgnoringCase(colorString, "currentcolor"))
         return ParsedCurrentColor;
-    if (BisonCSSParser::parseColor(parsedColor, colorString))
+    if (BisonCSSParser::parseColor(parsedColor, colorString, true /* strict */))

[Justin Novosad, 2014/04/16 16:26:49]

The Blinky way of documenting the meaning of 'true' would be to use an enum
instead of a bool. But since this is a pre-existing function, the alternative
would be to declare a constant

const bool useStrictParsing = true;
if (BisonCSSParser::parseColor(parsedColor, colorString, useStrictParsing))

[fs, 2014/04/16 16:34:10]

Ah, yes... I keep forgetting that rule (which think is nice.) Fixed.

         return ParsedRGBA;
     if (BisonCSSParser::parseSystemColor(parsedColor, colorString))
         return ParsedSystemColor;
     return ParseFailed;
 }
 
 RGBA32 currentColor(HTMLCanvasElement* canvas)
 {
     if (!canvas || !canvas->inDocument() || !canvas->inlineStyle())
         return Color::black;
@@ skipping 205 matching lines @@
         context->setFillPattern(canvasPattern()->pattern());
         break;
     case CurrentColor:
     case CurrentColorWithOverrideAlpha:
         ASSERT_NOT_REACHED();
         break;
     }
 }
 
 }