Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 237743007: Handle the DOMString case of CRC2D.fillStyle/strokeStyle correctly (Closed)

Created:
6 years, 8 months ago by fs
Modified:
6 years, 8 months ago
Reviewers:
haraken, Justin Novosad
CC:
blink-reviews, Nils Barth (inactive), arv+blink, jsbell+bindings_chromium.org, sof, kouhei+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive
Visibility:
Public.

Description

Handle the DOMString case of CRC2D.fillStyle/strokeStyle correctly Non-CanvasGradient/CanvasPattern objects would not be ToString(v)'d and have the result assigned/parsed as a color-string. Implement this by checking for CanvasGradient/CanvasPattern first, and then invole ToString() on the value. BUG=364008 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171852

Patch Set 1 #

Total comments: 6

Patch Set 2 : Simplify. #

Patch Set 3 : Add tests for numeric values; Simplify tests. #

Patch Set 4 : Add tests for objects without (explicit) toString. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -8 lines) Patch
A LayoutTests/fast/canvas/canvas-fillStyle-strokeStyle-stringification.html View 1 2 3 1 chunk +57 lines, -0 lines 0 comments Download
M Source/bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp View 1 2 chunks +12 lines, -8 lines 0 comments Download

Messages

Total messages: 23 (0 generated)
fs
6 years, 8 months ago (2014-04-16 14:15:51 UTC) #1
haraken
https://codereview.chromium.org/237743007/diff/1/Source/bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp File Source/bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp (right): https://codereview.chromium.org/237743007/diff/1/Source/bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp#newcode84 Source/bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:84: } I'm not sure if we need separate branches ...
6 years, 8 months ago (2014-04-16 14:18:27 UTC) #2
fs
https://codereview.chromium.org/237743007/diff/1/Source/bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp File Source/bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp (right): https://codereview.chromium.org/237743007/diff/1/Source/bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp#newcode84 Source/bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:84: } On 2014/04/16 14:18:27, haraken wrote: > > I'm ...
6 years, 8 months ago (2014-04-16 14:29:56 UTC) #3
fs
https://codereview.chromium.org/237743007/diff/1/Source/bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp File Source/bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp (right): https://codereview.chromium.org/237743007/diff/1/Source/bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp#newcode84 Source/bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:84: } On 2014/04/16 14:29:57, fs wrote: > On 2014/04/16 ...
6 years, 8 months ago (2014-04-16 15:09:53 UTC) #4
Justin Novosad
https://codereview.chromium.org/237743007/diff/1/Source/bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp File Source/bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp (right): https://codereview.chromium.org/237743007/diff/1/Source/bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp#newcode84 Source/bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:84: } V8StringResource::prepareBase starts by checking whether the cast is ...
6 years, 8 months ago (2014-04-16 15:16:18 UTC) #5
Justin Novosad
On 2014/04/16 15:16:18, junov wrote: > https://codereview.chromium.org/237743007/diff/1/Source/bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp > File Source/bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp (right): > > https://codereview.chromium.org/237743007/diff/1/Source/bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp#newcode84 > ...
6 years, 8 months ago (2014-04-16 15:24:10 UTC) #6
fs
https://codereview.chromium.org/237743007/diff/1/Source/bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp File Source/bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp (right): https://codereview.chromium.org/237743007/diff/1/Source/bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp#newcode84 Source/bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:84: } On 2014/04/16 15:16:18, junov wrote: > V8StringResource::prepareBase starts ...
6 years, 8 months ago (2014-04-16 15:30:19 UTC) #7
fs
On 2014/04/16 15:24:10, junov wrote: > On 2014/04/16 15:16:18, junov wrote: > > > https://codereview.chromium.org/237743007/diff/1/Source/bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp ...
6 years, 8 months ago (2014-04-16 15:43:20 UTC) #8
fs
On 2014/04/16 15:43:20, fs wrote: ... > though. (But it does end up stringifying to ...
6 years, 8 months ago (2014-04-16 15:44:28 UTC) #9
Justin Novosad
On 2014/04/16 15:30:19, fs wrote: > https://codereview.chromium.org/237743007/diff/1/Source/bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp > File Source/bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp (right): > > https://codereview.chromium.org/237743007/diff/1/Source/bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp#newcode84 > ...
6 years, 8 months ago (2014-04-16 15:49:09 UTC) #10
fs
On 2014/04/16 15:49:09, junov wrote: > On 2014/04/16 15:30:19, fs wrote: > > > https://codereview.chromium.org/237743007/diff/1/Source/bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp ...
6 years, 8 months ago (2014-04-16 15:57:44 UTC) #11
fs
On 2014/04/16 15:57:44, fs wrote: > On 2014/04/16 15:49:09, junov wrote: > > On 2014/04/16 ...
6 years, 8 months ago (2014-04-16 15:59:27 UTC) #12
fs
On 2014/04/16 15:59:27, fs wrote: > On 2014/04/16 15:57:44, fs wrote: > > On 2014/04/16 ...
6 years, 8 months ago (2014-04-16 16:16:14 UTC) #13
Justin Novosad
On 2014/04/16 16:16:14, fs wrote: > On 2014/04/16 15:59:27, fs wrote: > > On 2014/04/16 ...
6 years, 8 months ago (2014-04-16 16:27:37 UTC) #14
fs
On 2014/04/16 15:49:09, junov wrote: > On 2014/04/16 15:30:19, fs wrote: ... > About the ...
6 years, 8 months ago (2014-04-16 16:27:41 UTC) #15
Justin Novosad
On 2014/04/16 16:27:37, junov wrote: > On 2014/04/16 16:16:14, fs wrote: > > On 2014/04/16 ...
6 years, 8 months ago (2014-04-16 16:28:42 UTC) #16
fs
On 2014/04/16 16:28:42, junov wrote: > On 2014/04/16 16:27:37, junov wrote: > > On 2014/04/16 ...
6 years, 8 months ago (2014-04-16 16:39:15 UTC) #17
Justin Novosad
On 2014/04/16 16:39:15, fs wrote: > On 2014/04/16 16:28:42, junov wrote: > > On 2014/04/16 ...
6 years, 8 months ago (2014-04-16 16:55:46 UTC) #18
fs
On 2014/04/16 16:55:46, junov wrote: > On 2014/04/16 16:39:15, fs wrote: ... > > It's ...
6 years, 8 months ago (2014-04-16 17:20:43 UTC) #19
haraken
LGTM!
6 years, 8 months ago (2014-04-16 23:12:52 UTC) #20
fs
The CQ bit was checked by fs@opera.com
6 years, 8 months ago (2014-04-17 09:01:07 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/237743007/50001
6 years, 8 months ago (2014-04-17 09:01:20 UTC) #22
commit-bot: I haz the power
6 years, 8 months ago (2014-04-17 13:49:19 UTC) #23
Message was sent while issue was closed.
Change committed as 171852

Powered by Google App Engine
This is Rietveld 408576698