Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 2377273004: Reland: Start checking URLs using PVer4. Verdict not returned to client yet. (Closed)

Created:
4 years, 2 months ago by vakh (use Gerrit instead)
Modified:
4 years, 2 months ago
Reviewers:
Nathan Parker, mmenke
CC:
chromium-reviews, loading-reviews_chromium.org, grt+watch_chromium.org, Randy Smith (Not in Mondays), gone
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: Start checking URLs using PVer4. Verdict not returned to client yet. Reason for failure: The features that are enabled by Finch were also enabled by #DEBUG. This enabled them on the DEBUG build of Android, which is wrong. BUG=543161 TBR=mmenke Committed: https://crrev.com/939c27d111805a5c1e40212373bd4cb4864b7dc3 Cr-Commit-Position: refs/heads/master@{#422445}

Patch Set 1 : git revert f627f9a #

Patch Set 2 : Remove #DEBUG -- it enables these features on Android :-( #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -45 lines) Patch
M chrome/browser/loader/safe_browsing_resource_throttle.h View 3 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/loader/safe_browsing_resource_throttle.cc View 5 chunks +16 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/safe_browsing/services_delegate.h View 3 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/safe_browsing/services_delegate_impl.h View 2 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/safe_browsing/services_delegate_impl.cc View 5 chunks +7 lines, -26 lines 0 comments Download
M chrome/browser/safe_browsing/services_delegate_stub.h View 3 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/safe_browsing/services_delegate_stub.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M components/safe_browsing_db/BUILD.gn View 3 chunks +11 lines, -1 line 0 comments Download
A components/safe_browsing_db/v4_feature_list.h View 1 chunk +24 lines, -0 lines 0 comments Download
A components/safe_browsing_db/v4_feature_list.cc View 1 1 chunk +32 lines, -0 lines 0 comments Download
M components/safe_browsing_db/v4_local_database_manager.h View 2 chunks +17 lines, -12 lines 0 comments Download
M components/safe_browsing_db/v4_local_database_manager.cc View 2 chunks +12 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 24 (16 generated)
vakh (use Gerrit instead)
Remove #DEBUG -- it enables these features on Android :-(
4 years, 2 months ago (2016-09-30 02:05:45 UTC) #5
Nathan Parker
lgtm
4 years, 2 months ago (2016-09-30 18:59:58 UTC) #12
vakh (use Gerrit instead)
mmenke@ -- could you please review the changes in: chrome/browser/loader/safe_browsing_resource_throttle.* It is the same as: ...
4 years, 2 months ago (2016-09-30 19:34:24 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2377273004/20001
4 years, 2 months ago (2016-10-01 07:27:43 UTC) #16
mmenke
On 2016/10/01 07:27:43, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
4 years, 2 months ago (2016-10-03 14:34:32 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2377273004/20001
4 years, 2 months ago (2016-10-03 16:06:55 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-03 17:20:18 UTC) #22
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 17:22:07 UTC) #24
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/939c27d111805a5c1e40212373bd4cb4864b7dc3
Cr-Commit-Position: refs/heads/master@{#422445}

Powered by Google App Engine
This is Rietveld 408576698