Make target member of the TouchInit dictionary non-nullable

Make target member of the TouchInit dictionary non-nullable

BUG=647693, 651660
Committed: https://crrev.com/60342433ae665fc1c9f2ae8cb12186f29b523043
Cr-Commit-Position: refs/heads/master@{#422334}

[dhna, 2016-09-30 02:00:40]

Description was changed from

==========
make target non nullable

BUG= 651660
==========

to

==========
make target non nullable

BUG= 651660
==========

[dhna, 2016-09-30 02:00:40]

corona10@gmail.com changed reviewers:
+ jinho.bang@samsung.com

[zino, 2016-09-30 03:12:55]

The CQ bit was checked by jinho.bang@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 03:13:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 05:55:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 05:55:02]

Dry run: This issue passed the CQ dry run.

[dhna, 2016-09-30 06:56:23]

corona10@gmail.com changed reviewers:
+ eae@chromium.org

[dhna, 2016-09-30 06:56:24]

Now it pass this test
 http://w3c-test.org/touch-events/touch-touchevent-constructor.html

eae@ PTAL

[dhna, 2016-09-30 09:37:30]

corona10@gmail.com changed reviewers:
+ foolip@chromium.org

[dtapuska, 2016-09-30 14:35:12]

On 2016/09/30 06:56:24, dhna wrote:
> Now it pass this test
>  http://w3c-test.org/touch-events/touch-touchevent-constructor.html
> 
> eae@ PTAL

Can you make the commit message more detailed?

[dhna, 2016-09-30 15:00:48]

Description was changed from

==========
make target non nullable

BUG= 651660
==========

to

==========
make Touch constructor to be non nullable.

BUG= 651660
==========

[dhna, 2016-09-30 15:01:38]

On 2016/09/30 14:35:12, dtapuska wrote:
> On 2016/09/30 06:56:24, dhna wrote:
> > Now it pass this test
> >  http://w3c-test.org/touch-events/touch-touchevent-constructor.html
> > 
> > eae@ PTAL
> 
> Can you make the commit message more detailed?

dtapuska@
I changed the commit message to be more detailed.
PTAL

[foolip, 2016-09-30 15:18:03]

The CQ bit was checked by foolip@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 15:18:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[foolip, 2016-09-30 15:19:25]

Starting a dry run to see which tests will need updating.

It's not quite right to say that the Touch constructor is nullable, rather the
target member of the TouchInit dictionary is made non-nullable. (And please
capitalize "make" :)

[dhna, 2016-09-30 15:25:56]

Description was changed from

==========
make Touch constructor to be non nullable.

BUG= 651660
==========

to

==========
Make Touch constructor to be non nullable.

BUG= 651660
==========

[dhna, 2016-09-30 15:28:23]

Description was changed from

==========
Make Touch constructor to be non nullable.

BUG= 651660
==========

to

==========
Make target member of the TouchInit dictionary to be non-nullable.

BUG= 651660
==========

[dhna, 2016-09-30 15:49:41]

On 2016/09/30 15:19:25, foolip wrote:
> Starting a dry run to see which tests will need updating.
> 
> It's not quite right to say that the Touch constructor is nullable, rather the
> target member of the TouchInit dictionary is made non-nullable. (And please
> capitalize "make" :)

foolip@
I changed description. Thank you :-)

[commit-bot: I haz the power, 2016-09-30 17:21:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 17:21:55]

Dry run: This issue passed the CQ dry run.

[foolip, 2016-09-30 19:12:52]

Hmm, no tests are failing. A test for this is in wpt and I'm doing an import in
https://codereview.chromium.org/2376103007 after which this should fix a test.

[dhna, 2016-09-30 19:21:57]

On 2016/09/30 19:12:52, foolip wrote:
> Hmm, no tests are failing. A test for this is in wpt and I'm doing an import
in
> https://codereview.chromium.org/2376103007 after which this should fix a test.

foolip@
Thanks

[foolip, 2016-09-30 19:57:34]

On 2016/09/30 19:21:57, dhna wrote:
> On 2016/09/30 19:12:52, foolip wrote:
> > Hmm, no tests are failing. A test for this is in wpt and I'm doing an import
> in
> > https://codereview.chromium.org/2376103007 after which this should fix a
test.
> 
> foolip@
> Thanks

When that has landed you'll have to rebase and delete
touch-touchevent-constructor-expected.txt, as that test will then be passing.

lgtm to land at that point, be sure not to check CQ while
https://codereview.chromium.org/2376103007 is flight.

[foolip, 2016-09-30 19:58:03]

Description was changed from

==========
Make target member of the TouchInit dictionary to be non-nullable.

BUG= 651660
==========

to

==========
Make target member of the TouchInit dictionary non-nullable

BUG= 651660
==========

[foolip, 2016-09-30 19:58:27]

Description was changed from

==========
Make target member of the TouchInit dictionary non-nullable

BUG= 651660
==========

to

==========
Make target member of the TouchInit dictionary non-nullable

BUG=647693,651660
==========

[dhna, 2016-09-30 23:12:17]

On 2016/09/30 19:57:34, foolip wrote:
> On 2016/09/30 19:21:57, dhna wrote:
> > On 2016/09/30 19:12:52, foolip wrote:
> > > Hmm, no tests are failing. A test for this is in wpt and I'm doing an
import
> > in
> > > https://codereview.chromium.org/2376103007 after which this should fix a
> test.
> > 
> > foolip@
> > Thanks
> 
> When that has landed you'll have to rebase and delete
> touch-touchevent-constructor-expected.txt, as that test will then be passing.
> 
> lgtm to land at that point, be sure not to check CQ while
> https://codereview.chromium.org/2376103007 is flight.

Thanks I got it :-)

[zino, 2016-10-01 16:14:04]

The CQ bit was checked by jinho.bang@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-01 16:14:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dhna, 2016-10-01 17:29:02]

On 2016/09/30 23:12:17, dhna wrote:
> On 2016/09/30 19:57:34, foolip wrote:
> > On 2016/09/30 19:21:57, dhna wrote:
> > > On 2016/09/30 19:12:52, foolip wrote:
> > > > Hmm, no tests are failing. A test for this is in wpt and I'm doing an
> import
> > > in
> > > > https://codereview.chromium.org/2376103007 after which this should fix a
> > test.
> > > 
> > > foolip@
> > > Thanks
> > 
> > When that has landed you'll have to rebase and delete
> > touch-touchevent-constructor-expected.txt, as that test will then be
passing.
> > 
> > lgtm to land at that point, be sure not to check CQ while
> > https://codereview.chromium.org/2376103007 is flight.
> 
> Thanks I got it :-)

foolip@
PTAL

[commit-bot: I haz the power, 2016-10-01 17:41:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-01 17:41:06]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[foolip, 2016-10-01 19:51:21]

The CQ bit was checked by foolip@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-01 19:51:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-01 21:18:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-01 21:19:00]

Dry run: This issue passed the CQ dry run.

[foolip, 2016-10-01 23:19:53]

The CQ bit was checked by foolip@chromium.org

[foolip, 2016-10-01 23:19:54]

lgtm

Something is going on with overflow-anchor on linux_chromium_rel_ng, but it's
very unlikely because of this CL.

[commit-bot: I haz the power, 2016-10-01 23:20:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-01 23:24:43]

Description was changed from

==========
Make target member of the TouchInit dictionary non-nullable

BUG=647693,651660
==========

to

==========
Make target member of the TouchInit dictionary non-nullable

BUG=647693,651660
==========

[commit-bot: I haz the power, 2016-10-01 23:24:44]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-10-01 23:26:24]

Description was changed from

==========
Make target member of the TouchInit dictionary non-nullable

BUG=647693,651660
==========

to

==========
Make target member of the TouchInit dictionary non-nullable

BUG=647693,651660

Committed: https://crrev.com/60342433ae665fc1c9f2ae8cb12186f29b523043
Cr-Commit-Position: refs/heads/master@{#422334}
==========

[commit-bot: I haz the power, 2016-10-01 23:26:25]

Patchset 6 (id:??) landed as
https://crrev.com/60342433ae665fc1c9f2ae8cb12186f29b523043
Cr-Commit-Position: refs/heads/master@{#422334}

[dhna, 2016-10-02 00:03:01]

On 2016/10/01 23:19:54, foolip wrote:
> lgtm
> 
> Something is going on with overflow-anchor on linux_chromium_rel_ng, but it's
> very unlikely because of this CL.

thanks