third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js - Issue 2377193004: [DevTools] Rework some focus code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js

Issue 2377193004: [DevTools] Rework some focus code. (Closed)

Patch Set: fixes Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/main/Main.js ('K') | « third_party/WebKit/Source/devtools/front_end/sources/AdvancedSearchView.js ('k') | third_party/WebKit/Source/devtools/front_end/text_editor/CodeMirrorUtils.js » ('j') | third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js b/third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js

index a7debf6cf6401a1544d4b7c378cdc20e9305f2a5..1f96cfa257e1bcfd61bdd25c657e792342ebe317 100644

--- a/third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js

+++ b/third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js

@@ -979,9 +979,7 @@ WebInspector.NavigatorSourceTreeElement.prototype = {

if (!this._uiSourceCode.canRename())

return false;

var isSelected = this === this.treeOutline.selectedTreeElement;

- var document = this.treeOutline.element.ownerDocument;

- var isFocused = this.treeOutline.element.isSelfOrAncestor(document.activeElement);

- return isSelected && isFocused && !WebInspector.isBeingEdited(this.treeOutline.element);

+ return isSelected && this.treeOutline.element.hasFocus() && !WebInspector.isBeingEdited(this.treeOutline.element);

selectOnMouseDown: function(event)