third_party/WebKit/Source/devtools/front_end/main/Main.js - Issue 2377193004: [DevTools] Rework some focus code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/main/Main.js

Issue 2377193004: [DevTools] Rework some focus code. (Closed)

Patch Set: fixes Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/externs.js ('K') | « third_party/WebKit/Source/devtools/front_end/externs.js ('k') | third_party/WebKit/Source/devtools/front_end/platform/DOMExtension.js » ('j') | third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/main/Main.js

diff --git a/third_party/WebKit/Source/devtools/front_end/main/Main.js b/third_party/WebKit/Source/devtools/front_end/main/Main.js

index cf8b62f16c05a35868bc9e124918d46a78606721..65a1af273e534ffe67c07b1e157604b953e79a5a 100644

--- a/third_party/WebKit/Source/devtools/front_end/main/Main.js

+++ b/third_party/WebKit/Source/devtools/front_end/main/Main.js

@@ -663,10 +663,11 @@ WebInspector.Main.SearchActionDelegate.prototype = {

* @param {!WebInspector.Context} context

* @param {string} actionId

* @return {boolean}

+ * @suppressGlobalPropertiesCheck

handleAction: function(context, actionId)

{

- var searchableView = WebInspector.SearchableView.fromElement(WebInspector.currentFocusElement()) || WebInspector.inspectorView.currentPanel().searchableView();

+ var searchableView = WebInspector.SearchableView.fromElement(document.deepActiveElement()) || WebInspector.inspectorView.currentPanel().searchableView();

pfeldman 2016/09/30 22:29:03 which document?

if (!searchableView)

return false;

switch (actionId) {