VideoCaptureImpl cleanup: merge ctor+Init() and DeInit()+dtor.

content/renderer/media/video_capture_impl.h

Index: content/renderer/media/video_capture_impl.h
diff --git a/content/renderer/media/video_capture_impl.h b/content/renderer/media/video_capture_impl.h
index 419af4f749abcdd5a804cbed726de0b2b897f4ac..0c5da227f14426698ad329d7320f9f1ceaed020d 100644
--- a/content/renderer/media/video_capture_impl.h
+++ b/content/renderer/media/video_capture_impl.h
@@ -48,14 +48,10 @@ class CONTENT_EXPORT VideoCaptureImpl
  public:
   ~VideoCaptureImpl() override;
 
-  VideoCaptureImpl(media::VideoCaptureSessionId session_id,
-                   VideoCaptureMessageFilter* filter);
-
-  // Start listening to IPC messages.
-  void Init();
-
-  // Stop listening to IPC messages.
-  void DeInit();
+  VideoCaptureImpl(
+      media::VideoCaptureSessionId session_id,
+      VideoCaptureMessageFilter* filter,
+      const scoped_refptr<base::SingleThreadTaskRunner>& io_task_runner);

[miu, 2016/09/29 06:59:40]

Please use new smart pointer arg-passing style: The 3rd arg should be passed by
value, not by const-ref:

  scoped_refptr<base::SingleThreadTaskRunner> io_task_runner

Then, in the ctor initializer list:

  io_task_runner_(std::move(io_task_runner))

(to prevent the excessive ref count inc+dec operation)

[mcasas, 2016/09/29 14:42:41]

Done.

 
   // Stop/resume delivering video frames to clients, based on flag |suspend|.
   void SuspendCapture(bool suspend);
@@ -198,7 +194,7 @@ class CONTENT_EXPORT VideoCaptureImpl
   VideoCaptureState state_;
 
   // IO message loop reference for checking correct class operation.
-  scoped_refptr<base::SingleThreadTaskRunner> io_task_runner_;
+  const scoped_refptr<base::SingleThreadTaskRunner> io_task_runner_;
 
   // WeakPtrFactory pointing back to |this| object, for use with
   // media::VideoFrames constructed in OnBufferReceived() from buffers cached