VideoCaptureImpl cleanup: merge ctor+Init() and DeInit()+dtor.

content/renderer/media/video_capture_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_RENDERER_MEDIA_VIDEO_CAPTURE_IMPL_H_
 #define CONTENT_RENDERER_MEDIA_VIDEO_CAPTURE_IMPL_H_
 
 #include <stdint.h>
 
 #include <list>
@@ skipping 30 matching lines @@
 // video_capture_impl_manager.cc for the lifetime of this object.
 // All methods must be called on the IO thread.
 //
 // This is an internal class used by VideoCaptureImplManager only. Do not access
 // this directly.
 class CONTENT_EXPORT VideoCaptureImpl
     : public VideoCaptureMessageFilter::Delegate {
  public:
   ~VideoCaptureImpl() override;
 
-  VideoCaptureImpl(media::VideoCaptureSessionId session_id,
-                   VideoCaptureMessageFilter* filter);
-
-  // Start listening to IPC messages.
-  void Init();
-
-  // Stop listening to IPC messages.
-  void DeInit();
+  VideoCaptureImpl(
+      media::VideoCaptureSessionId session_id,
+      VideoCaptureMessageFilter* filter,
+      const scoped_refptr<base::SingleThreadTaskRunner>& io_task_runner);

[miu, 2016/09/29 06:59:40]

Please use new smart pointer arg-passing style: The 3rd arg should be passed by
value, not by const-ref:

  scoped_refptr<base::SingleThreadTaskRunner> io_task_runner

Then, in the ctor initializer list:

  io_task_runner_(std::move(io_task_runner))

(to prevent the excessive ref count inc+dec operation)

[mcasas, 2016/09/29 14:42:41]

Done.

 
   // Stop/resume delivering video frames to clients, based on flag |suspend|.
   void SuspendCapture(bool suspend);
 
   // Start capturing using the provided parameters.
   // |client_id| must be unique to this object in the render process. It is
   // used later to stop receiving video frames.
   // |state_update_cb| will be called when state changes.
   // |deliver_frame_cb| will be called when a frame is ready.
   void StartCapture(int client_id,
@@ skipping 122 matching lines @@
   media::VideoCaptureParams params_;
 
   // The device's first captured frame referecne time sent from browser process
   // side.
   base::TimeTicks first_frame_ref_time_;
 
   bool suspended_;
   VideoCaptureState state_;
 
   // IO message loop reference for checking correct class operation.
-  scoped_refptr<base::SingleThreadTaskRunner> io_task_runner_;
+  const scoped_refptr<base::SingleThreadTaskRunner> io_task_runner_;
 
   // WeakPtrFactory pointing back to |this| object, for use with
   // media::VideoFrames constructed in OnBufferReceived() from buffers cached
   // in |client_buffers_|.
   // NOTE: Weak pointers must be invalidated before all other member variables.
   base::WeakPtrFactory<VideoCaptureImpl> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(VideoCaptureImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_RENDERER_MEDIA_VIDEO_CAPTURE_IMPL_H_