Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(837)

Unified Diff: test/upgrade/git/upgrade_to_incompatible_pubspec_test.dart

Issue 2377063002: Make "--no-packages-dir" the default. (Closed)
Patch Set: Revise again. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/upgrade/git/upgrade_to_incompatible_pubspec_test.dart
diff --git a/test/upgrade/git/upgrade_to_incompatible_pubspec_test.dart b/test/upgrade/git/upgrade_to_incompatible_pubspec_test.dart
index 670a535d1ede8a1d9a9dbdb34f24273e114321b4..e6692514e27afea27936c05f35951a8104652380 100644
--- a/test/upgrade/git/upgrade_to_incompatible_pubspec_test.dart
+++ b/test/upgrade/git/upgrade_to_incompatible_pubspec_test.dart
@@ -19,7 +19,9 @@ main() {
d.appDir({"foo": {"git": "../foo.git"}}).create();
- pubGet();
+ // TODO(rnystrom): Remove "--packages-dir" and validate using the
+ // ".packages" file instead of looking in the "packages" directory.
+ pubGet(args: ["--packages-dir"]);
d.dir(packagesPath, [
d.dir('foo', [
@@ -32,8 +34,12 @@ main() {
d.libPubspec('zoo', '1.0.0')
]).commit();
- pubUpgrade(error: contains('"name" field doesn\'t match expected name '
- '"foo".'), exitCode: exit_codes.DATA);
+ // TODO(rnystrom): Remove "--packages-dir" and validate using the
+ // ".packages" file instead of looking in the "packages" directory.
+ pubUpgrade(
+ args: ['--packages-dir'],
+ error: contains('"name" field doesn\'t match expected name "foo".'),
+ exitCode: exit_codes.DATA);
d.dir(packagesPath, [
d.dir('foo', [
« no previous file with comments | « test/upgrade/git/upgrade_one_locked_test.dart ('k') | test/upgrade/git/upgrade_to_nonexistent_pubspec_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698