Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Unified Diff: test/upgrade/git/upgrade_to_nonexistent_pubspec_test.dart

Issue 2377063002: Make "--no-packages-dir" the default. (Closed)
Patch Set: Revise again. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/upgrade/git/upgrade_to_nonexistent_pubspec_test.dart
diff --git a/test/upgrade/git/upgrade_to_nonexistent_pubspec_test.dart b/test/upgrade/git/upgrade_to_nonexistent_pubspec_test.dart
index 19918618bfb1a92305a2e02e9cb06ecb78bbdfe5..23facedc3eedb813b08943e926d00148698b2046 100644
--- a/test/upgrade/git/upgrade_to_nonexistent_pubspec_test.dart
+++ b/test/upgrade/git/upgrade_to_nonexistent_pubspec_test.dart
@@ -17,7 +17,9 @@ main() {
d.appDir({"foo": {"git": "../foo.git"}}).create();
- pubGet();
+ // TODO(rnystrom): Remove "--packages-dir" and validate using the
+ // ".packages" file instead of looking in the "packages" directory.
+ pubGet(args: ["--packages-dir"]);
d.dir(packagesPath, [
d.dir('foo', [
@@ -28,8 +30,12 @@ main() {
repo.runGit(['rm', 'pubspec.yaml']);
repo.runGit(['commit', '-m', 'delete']);
- pubUpgrade(error: new RegExp(r'Could not find a file named "pubspec.yaml" '
- r'in [^\n]*\.'));
+ // TODO(rnystrom): Remove "--packages-dir" and validate using the
+ // ".packages" file instead of looking in the "packages" directory.
+ pubUpgrade(
+ args: ["--packages-dir"],
+ error: new RegExp(r'Could not find a file named "pubspec.yaml" '
+ r'in [^\n]*\.'));
d.dir(packagesPath, [
d.dir('foo', [
« no previous file with comments | « test/upgrade/git/upgrade_to_incompatible_pubspec_test.dart ('k') | test/upgrade/hosted/unlock_dependers_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698