Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Unified Diff: test/implicit_barback_dependency_test.dart

Issue 2377063002: Make "--no-packages-dir" the default. (Closed)
Patch Set: Revise again. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/hosted/remove_removed_transitive_dependency_test.dart ('k') | test/implicit_dependency_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/implicit_barback_dependency_test.dart
diff --git a/test/implicit_barback_dependency_test.dart b/test/implicit_barback_dependency_test.dart
index 23954cfb794603155cfc8c1d5d1a92feb3179368..a53cf0e0fd0fd93c8a5b726811ee00f318afa796 100644
--- a/test/implicit_barback_dependency_test.dart
+++ b/test/implicit_barback_dependency_test.dart
@@ -38,8 +38,11 @@ main() {
pubCommand(command);
- d.packagesDir({
- "barback": nextPatch
+ d.appPackagesFile({
+ "async": asyncVersion,
+ "barback": nextPatch,
+ "source_span": sourceSpanVersion,
+ "stack_trace": stackTraceVersion
}).validate();
});
@@ -67,9 +70,12 @@ main() {
pubCommand(command);
- d.packagesDir({
+ d.appPackagesFile({
+ "async": asyncVersion,
"barback": nextPatch,
- "foo": "0.0.1"
+ "source_span": sourceSpanVersion,
+ "stack_trace": stackTraceVersion,
+ "foo": "../foo"
}).validate();
});
@@ -97,8 +103,11 @@ main() {
pubCommand(command);
- d.packagesDir({
- "barback": current
+ d.appPackagesFile({
+ "async": asyncVersion,
+ "barback": "../barback",
+ "source_span": sourceSpanVersion,
+ "stack_trace": stackTraceVersion,
}).validate();
});
});
@@ -122,8 +131,11 @@ main() {
pubGet();
// It should be upgraded.
- d.packagesDir({
- "barback": current
+ d.appPackagesFile({
+ "async": asyncVersion,
+ "barback": current,
+ "source_span": sourceSpanVersion,
+ "stack_trace": stackTraceVersion,
}).validate();
});
« no previous file with comments | « test/hosted/remove_removed_transitive_dependency_test.dart ('k') | test/implicit_dependency_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698