Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4615)

Unified Diff: build/config/compiler/compiler.gni

Issue 2377013002: Assert that the chosen Android config is safe. (Closed)
Patch Set: Move to compiler.gni Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/compiler.gni
diff --git a/build/config/compiler/compiler.gni b/build/config/compiler/compiler.gni
index 5b51fafa974721771f2863984672798cb41a3646..cc8f5a1472e7cfd2975790cb2de164cd51810b3d 100644
--- a/build/config/compiler/compiler.gni
+++ b/build/config/compiler/compiler.gni
@@ -102,3 +102,9 @@ if (symbol_level == -1) {
symbol_level = 0
}
}
+
+# Assert that the configuration isn't going to hit https://crbug.com/648948.
+assert(!is_android || android_64bit_target_cpu || is_component_build ||
+ symbol_level < 2,
+ "Android 32-bit non-component builds cannot have symbol_level=2 " +
+ "due to 4GiB file size limit, see https://crbug.com/648948")
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698