Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Side by Side Diff: build/config/compiler/compiler.gni

Issue 2377013002: Assert that the chosen Android config is safe. (Closed)
Patch Set: Move to compiler.gni Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/chromecast_build.gni") 7 import("//build/config/chromecast_build.gni")
8 import("//build/config/sanitizers/sanitizers.gni") 8 import("//build/config/sanitizers/sanitizers.gni")
9 import("//build/toolchain/goma.gni") 9 import("//build/toolchain/goma.gni")
10 import("//build/toolchain/toolchain.gni") 10 import("//build/toolchain/toolchain.gni")
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
95 # Mac and Windows have them separate, so in Release Linux, default them off, 95 # Mac and Windows have them separate, so in Release Linux, default them off,
96 # but keep them on for Official builds and Chromecast builds. 96 # but keep them on for Official builds and Chromecast builds.
97 symbol_level = 2 97 symbol_level = 2
98 } else if (using_sanitizer) { 98 } else if (using_sanitizer) {
99 # Sanitizers require symbols for filename suppressions to work. 99 # Sanitizers require symbols for filename suppressions to work.
100 symbol_level = 1 100 symbol_level = 1
101 } else { 101 } else {
102 symbol_level = 0 102 symbol_level = 0
103 } 103 }
104 } 104 }
105
106 # Assert that the configuration isn't going to hit https://crbug.com/648948.
107 assert(!is_android || android_64bit_target_cpu || is_component_build ||
108 symbol_level < 2,
109 "Android 32-bit non-component builds cannot have symbol_level=2 " +
110 "due to 4GiB file size limit, see https://crbug.com/648948")
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698