Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2376953002: [tracing] r39794 follow-up: Update the missing part of the test. (Closed)

Created:
4 years, 2 months ago by alph
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[tracing] r39794 follow-up: Update the missing part of the test. The test now checks the case when an observer is added after tracing is started. BUG=chromium:406277 Committed: https://crrev.com/57b0e37443e7e9938f9e261d2e7c26a5688261f3 Cr-Commit-Position: refs/heads/master@{#39874}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M test/cctest/libplatform/test-tracing.cc View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
alph
4 years, 2 months ago (2016-09-28 07:10:37 UTC) #4
fmeawad
lgtm Thanks.
4 years, 2 months ago (2016-09-28 18:13:56 UTC) #7
jochen (gone - plz use gerrit)
lgtm
4 years, 2 months ago (2016-09-29 12:07:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2376953002/1
4 years, 2 months ago (2016-09-29 14:32:43 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-29 15:13:29 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 15:13:59 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/57b0e37443e7e9938f9e261d2e7c26a5688261f3
Cr-Commit-Position: refs/heads/master@{#39874}

Powered by Google App Engine
This is Rietveld 408576698