Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Side by Side Diff: test/cctest/libplatform/test-tracing.cc

Issue 2376953002: [tracing] r39794 follow-up: Update the missing part of the test. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 the V8 project authors. All rights reserved. 1 // Copyright 2016 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 #include <limits> 4 #include <limits>
5 5
6 #include "include/libplatform/v8-tracing.h" 6 #include "include/libplatform/v8-tracing.h"
7 #include "src/tracing/trace-event.h" 7 #include "src/tracing/trace-event.h"
8 #include "test/cctest/cctest.h" 8 #include "test/cctest/cctest.h"
9 9
10 namespace v8 { 10 namespace v8 {
(...skipping 354 matching lines...) Expand 10 before | Expand all | Expand 10 after
365 default_platform->AddTraceStateObserver(&observer); 365 default_platform->AddTraceStateObserver(&observer);
366 366
367 CHECK_EQ(0, observer.enabled_count); 367 CHECK_EQ(0, observer.enabled_count);
368 CHECK_EQ(0, observer.disabled_count); 368 CHECK_EQ(0, observer.disabled_count);
369 369
370 tracing_controller.StartTracing(trace_config); 370 tracing_controller.StartTracing(trace_config);
371 371
372 CHECK_EQ(1, observer.enabled_count); 372 CHECK_EQ(1, observer.enabled_count);
373 CHECK_EQ(0, observer.disabled_count); 373 CHECK_EQ(0, observer.disabled_count);
374 374
375 TraceStateObserverImpl observer2;
376 default_platform->AddTraceStateObserver(&observer2);
377
378 CHECK_EQ(1, observer2.enabled_count);
379 CHECK_EQ(0, observer2.disabled_count);
380
381 default_platform->RemoveTraceStateObserver(&observer2);
382
383 CHECK_EQ(1, observer2.enabled_count);
384 CHECK_EQ(0, observer2.disabled_count);
385
375 tracing_controller.StopTracing(); 386 tracing_controller.StopTracing();
376 387
377 CHECK_EQ(1, observer.enabled_count); 388 CHECK_EQ(1, observer.enabled_count);
378 CHECK_EQ(1, observer.disabled_count); 389 CHECK_EQ(1, observer.disabled_count);
390 CHECK_EQ(1, observer2.enabled_count);
391 CHECK_EQ(0, observer2.disabled_count);
379 392
380 default_platform->RemoveTraceStateObserver(&observer); 393 default_platform->RemoveTraceStateObserver(&observer);
381 394
382 CHECK_EQ(1, observer.enabled_count); 395 CHECK_EQ(1, observer.enabled_count);
383 CHECK_EQ(1, observer.disabled_count); 396 CHECK_EQ(1, observer.disabled_count);
384 397
385 trace_config = new v8::platform::tracing::TraceConfig(); 398 trace_config = new v8::platform::tracing::TraceConfig();
386 tracing_controller.StartTracing(trace_config); 399 tracing_controller.StartTracing(trace_config);
387 tracing_controller.StopTracing(); 400 tracing_controller.StopTracing();
388 401
389 CHECK_EQ(1, observer.enabled_count); 402 CHECK_EQ(1, observer.enabled_count);
390 CHECK_EQ(1, observer.disabled_count); 403 CHECK_EQ(1, observer.disabled_count);
391 404
392 i::V8::SetPlatformForTesting(old_platform); 405 i::V8::SetPlatformForTesting(old_platform);
393 } 406 }
394 407
395 } // namespace tracing 408 } // namespace tracing
396 } // namespace platform 409 } // namespace platform
397 } // namespace v8 410 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698