[Bindings] Drop a global variable 'interfaces' in v8_globals

Drop a global variable 'interfaces' in v8_globals

This variable was just used to resolve an extended attribute 'PutForwards'.
So that, its elements were defined once for each interface code generation.

This CL changes to pass those interfaces as an argument, not through a
global variable.

BUG=650150
Committed: https://crrev.com/5a59ca9a1fb80c68a78d3d8e2a5fc51d9af0b5fc
Cr-Commit-Position: refs/heads/master@{#421469}

[peria, 2016-09-28 04:38:45]

Description was changed from

==========
Drop a global variable 'interfaces' from v8_globals in bindings layer

BUG=650150
==========

to

==========
Drop a global variable 'interfaces' in v8_globals

This variable was just used to resolve an extended attribute 'PutForwards'.
So that, its elements were defined once for each interface code generation.

This CL changes to pass those interfaces as an argument, not through a
global variable.



BUG=650150
==========

[peria, 2016-09-28 04:39:00]

Patchset #1 (id:1) has been deleted

[peria, 2016-09-28 04:39:21]

peria@chromium.org changed reviewers:
+ bashi@chromium.org, yukishiino@chromium.org

[peria, 2016-09-28 04:39:22]

PTL

[haraken, 2016-09-28 04:47:15]

LGTM

[Yuki, 2016-09-28 04:48:16]

LGTM.

I think this is a good chance to add pydoc to describe what arguments are.  I'm
afraid that taking |interface| and |interfaces| would be a bit confusing.

[peria, 2016-09-28 05:45:41]

On 2016/09/28 04:48:16, Yuki wrote:
> LGTM.
> 
> I think this is a good chance to add pydoc to describe what arguments are. 
I'm
> afraid that taking |interface| and |interfaces| would be a bit confusing.

Done.

Please take another look.
I couldn't find guidance how comments should be written.

[Yuki, 2016-09-28 05:57:46]

On 2016/09/28 05:45:41, peria wrote:
> On 2016/09/28 04:48:16, Yuki wrote:
> > LGTM.
> > 
> > I think this is a good chance to add pydoc to describe what arguments are. 
> I'm
> > afraid that taking |interface| and |interfaces| would be a bit confusing.
> 
> Done.
> 
> Please take another look.
> I couldn't find guidance how comments should be written.

I think we can follow this style guideline.
https://google.github.io/styleguide/pyguide.html?showone=Comments#Comments

Once you updated the doc format, please go ahead to land the CL.

[peria, 2016-09-28 06:06:52]

On 2016/09/28 05:57:46, Yuki wrote:
> On 2016/09/28 05:45:41, peria wrote:
> > On 2016/09/28 04:48:16, Yuki wrote:
> > > LGTM.
> > > 
> > > I think this is a good chance to add pydoc to describe what arguments are.

> > I'm
> > > afraid that taking |interface| and |interfaces| would be a bit confusing.
> > 
> > Done.
> > 
> > Please take another look.
> > I couldn't find guidance how comments should be written.
> 
> I think we can follow this style guideline.
> https://google.github.io/styleguide/pyguide.html?showone=Comments#Comments
> 
> Once you updated the doc format, please go ahead to land the CL.

Thank you for the link!
Done.

[peria, 2016-09-28 06:07:15]

The CQ bit was checked by peria@chromium.org

[peria, 2016-09-28 06:07:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, yukishiino@chromium.org
Link to the patchset: https://codereview.chromium.org/2376913002/#ps60001
(title: "Update documents")

[commit-bot: I haz the power, 2016-09-28 06:07:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 07:49:14]

Description was changed from

==========
Drop a global variable 'interfaces' in v8_globals

This variable was just used to resolve an extended attribute 'PutForwards'.
So that, its elements were defined once for each interface code generation.

This CL changes to pass those interfaces as an argument, not through a
global variable.



BUG=650150
==========

to

==========
Drop a global variable 'interfaces' in v8_globals

This variable was just used to resolve an extended attribute 'PutForwards'.
So that, its elements were defined once for each interface code generation.

This CL changes to pass those interfaces as an argument, not through a
global variable.



BUG=650150
==========

[commit-bot: I haz the power, 2016-09-28 07:49:15]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-09-28 07:51:27]

Description was changed from

==========
Drop a global variable 'interfaces' in v8_globals

This variable was just used to resolve an extended attribute 'PutForwards'.
So that, its elements were defined once for each interface code generation.

This CL changes to pass those interfaces as an argument, not through a
global variable.



BUG=650150
==========

to

==========
Drop a global variable 'interfaces' in v8_globals

This variable was just used to resolve an extended attribute 'PutForwards'.
So that, its elements were defined once for each interface code generation.

This CL changes to pass those interfaces as an argument, not through a
global variable.

BUG=650150

Committed: https://crrev.com/5a59ca9a1fb80c68a78d3d8e2a5fc51d9af0b5fc
Cr-Commit-Position: refs/heads/master@{#421469}
==========

[commit-bot: I haz the power, 2016-09-28 07:51:28]

Patchset 3 (id:??) landed as
https://crrev.com/5a59ca9a1fb80c68a78d3d8e2a5fc51d9af0b5fc
Cr-Commit-Position: refs/heads/master@{#421469}