Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Unified Diff: third_party/WebKit/Source/bindings/scripts/code_generator_v8.py

Issue 2376913002: [Bindings] Drop a global variable 'interfaces' in v8_globals (Closed)
Patch Set: Update documents Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/scripts/v8_attributes.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/scripts/code_generator_v8.py
diff --git a/third_party/WebKit/Source/bindings/scripts/code_generator_v8.py b/third_party/WebKit/Source/bindings/scripts/code_generator_v8.py
index 776a3f59600dfdf6d03bc1ba7a6732c34dc40f6b..5ea7d1c3dc778f474176c16723ac1791c11065e7 100644
--- a/third_party/WebKit/Source/bindings/scripts/code_generator_v8.py
+++ b/third_party/WebKit/Source/bindings/scripts/code_generator_v8.py
@@ -54,7 +54,7 @@ from idl_types import IdlType
import v8_callback_function
import v8_callback_interface
import v8_dictionary
-from v8_globals import includes, interfaces
+from v8_globals import includes
import v8_interface
import v8_types
import v8_union
@@ -170,9 +170,6 @@ class CodeGeneratorV8(CodeGeneratorV8Base):
raise ValueError('%s is not in IDL definitions' % definition_name)
def generate_interface_code(self, definitions, interface_name, interface):
- # Store other interfaces for introspection
- interfaces.update(definitions.interfaces)
-
interface_info = self.info_provider.interfaces_info[interface_name]
full_path = interface_info.get('full_path')
component = idl_filename_to_component(full_path)
@@ -196,7 +193,7 @@ class CodeGeneratorV8(CodeGeneratorV8Base):
cpp_template_filename = 'interface.cpp.tmpl'
interface_context = v8_interface.interface_context
- template_context = interface_context(interface)
+ template_context = interface_context(interface, definitions.interfaces)
includes.update(interface_info.get('cpp_includes', {}).get(component, set()))
if not interface.is_partial and not is_testing_target(full_path):
template_context['header_includes'].add(self.info_provider.include_path_for_export)
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/scripts/v8_attributes.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698