Change PermissionContextBase to always return CONTENT_SETTING_ASK if a user dismisses the prompt

Change PermissionContextBase to always return CONTENT_SETTING_ASK if a user dismisses the prompt

Currently if a user dismisses the prompt, we will return the default value for
the content setting related to that prompt. Right now this will always be
CONTENT_SETTING_ASK for all settings that have a prompt. With flash (which we
are adding a prompt for) the default setting is DETECT. However it seems to be
more consistent and easier to reason about to always return ASK in this case
and the caller of the API can respond appropriately.

BUG=650825
Committed: https://crrev.com/423d965fe94116587295cffe206e7c6372494d7e
Cr-Commit-Position: refs/heads/master@{#421696}

[raymes, 2016-09-28 02:11:49]

raymes@chromium.org changed reviewers:
+ dominickn@chromium.org

[raymes, 2016-09-28 02:11:49]

Hey Dom, ptal. This fixes the crash mentioned in the associated bug. The test in
https://codereview.chromium.org/2361453004/ will cover this case.

[dominickn, 2016-09-28 07:05:20]

lgtm

[raymes, 2016-09-28 23:21:21]

The CQ bit was checked by raymes@chromium.org

[commit-bot: I haz the power, 2016-09-28 23:21:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 00:47:30]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-29 00:53:48]

Description was changed from

==========
Change PermissionContextBase to always return CONTENT_SETTING_ASK if a user
dismisses the prompt

Currently if a user dismisses the prompt, we will return the default value for
the content setting related to that prompt. Right now this will always be
CONTENT_SETTING_ASK for all settings that have a prompt. With flash (which we
are adding a prompt for) the default setting is DETECT. However it seems to be
more consistent and easier to reason about to always return ASK in this case
and the caller of the API can respond appropriately.

BUG=650825
==========

to

==========
Change PermissionContextBase to always return CONTENT_SETTING_ASK if a user
dismisses the prompt

Currently if a user dismisses the prompt, we will return the default value for
the content setting related to that prompt. Right now this will always be
CONTENT_SETTING_ASK for all settings that have a prompt. With flash (which we
are adding a prompt for) the default setting is DETECT. However it seems to be
more consistent and easier to reason about to always return ASK in this case
and the caller of the API can respond appropriately.

BUG=650825

Committed: https://crrev.com/423d965fe94116587295cffe206e7c6372494d7e
Cr-Commit-Position: refs/heads/master@{#421696}
==========

[commit-bot: I haz the power, 2016-09-29 00:53:49]

Patchset 1 (id:??) landed as
https://crrev.com/423d965fe94116587295cffe206e7c6372494d7e
Cr-Commit-Position: refs/heads/master@{#421696}