Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2428)

Unified Diff: chrome/browser/permissions/permission_context_base.cc

Issue 2376893002: Change PermissionContextBase to always return CONTENT_SETTING_ASK if a user dismisses the prompt (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/permissions/permission_context_base.cc
diff --git a/chrome/browser/permissions/permission_context_base.cc b/chrome/browser/permissions/permission_context_base.cc
index 341e3f70776a2c4eb6be20facfeb3b2e08c92fba..8e0e4ee83e3697a44fe5870c92d1c88955b8ffd9 100644
--- a/chrome/browser/permissions/permission_context_base.cc
+++ b/chrome/browser/permissions/permission_context_base.cc
@@ -273,13 +273,9 @@ void PermissionContextBase::NotifyPermissionSet(
UpdateTabContext(id, requesting_origin,
content_setting == CONTENT_SETTING_ALLOW);
- if (content_setting == CONTENT_SETTING_DEFAULT) {
- content_setting =
- HostContentSettingsMapFactory::GetForProfile(profile_)
- ->GetDefaultContentSetting(content_settings_type_, nullptr);
- }
+ if (content_setting == CONTENT_SETTING_DEFAULT)
+ content_setting = CONTENT_SETTING_ASK;
- DCHECK_NE(content_setting, CONTENT_SETTING_DEFAULT);
callback.Run(content_setting);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698