Implement commit for unaccelerated canvas with GPU compositing

Implement commit for unaccelerated canvas with GPU compositing

This CL implements OffscreenCanvas2d's commit API in the case where the
canvas is not GPU-accelerated, but the compositor is. In this case, we
extract a StaticBitmapImage from the imageBuffer, upload the CPU memory
that the StaticBitmapImage holds to GPU texture, and prepare a
CompositorFrame from the GPU texture.

A GPU pixel test is added to test this code path.

BUG=563852
TBR=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Committed: https://crrev.com/5371a41d019eb15db652d406a7c0f63ea179cbbe
Cr-Commit-Position: refs/heads/master@{#422927}

[xidachen, 2016-09-27 17:40:05]

Description was changed from

==========
WIP: Implement commit for unaccelerated canvas with GPU compositing

This CL implements OffscreenCanvas2d's commit API in the case where the
canvas is not GPU-accelerated, but the compositor is. In this case, we
extract a StaticBitmapImage from the imageBuffer, upload the CPU memory
that the StaticBitmapImage holds to GPU texture, and prepare a
CompositorFrame from the GPU texture.

A GPU pixel test is added to test this code path.

BUG=563852
==========

to

==========
WIP: Implement commit for unaccelerated canvas with GPU compositing

This CL implements OffscreenCanvas2d's commit API in the case where the
canvas is not GPU-accelerated, but the compositor is. In this case, we
extract a StaticBitmapImage from the imageBuffer, upload the CPU memory
that the StaticBitmapImage holds to GPU texture, and prepare a
CompositorFrame from the GPU texture.

A GPU pixel test is added to test this code path.

BUG=563852
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[xidachen, 2016-10-04 13:20:18]

Description was changed from

==========
WIP: Implement commit for unaccelerated canvas with GPU compositing

This CL implements OffscreenCanvas2d's commit API in the case where the
canvas is not GPU-accelerated, but the compositor is. In this case, we
extract a StaticBitmapImage from the imageBuffer, upload the CPU memory
that the StaticBitmapImage holds to GPU texture, and prepare a
CompositorFrame from the GPU texture.

A GPU pixel test is added to test this code path.

BUG=563852
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
Implement commit for unaccelerated canvas with GPU compositing

This CL implements OffscreenCanvas2d's commit API in the case where the
canvas is not GPU-accelerated, but the compositor is. In this case, we
extract a StaticBitmapImage from the imageBuffer, upload the CPU memory
that the StaticBitmapImage holds to GPU texture, and prepare a
CompositorFrame from the GPU texture.

A GPU pixel test is added to test this code path.

BUG=563852
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[xidachen, 2016-10-04 13:20:32]

xidachen@chromium.org changed reviewers:
+ junov@chromium.org, kbr@chromium.org

[xidachen, 2016-10-04 13:20:32]

PTAL

[Justin Novosad, 2016-10-04 14:20:48]

https://codereview.chromium.org/2376743002/diff/100001/third_party/WebKit/Sou...
File
third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp
(right):

https://codereview.chromium.org/2376743002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp:90:
// Try to optimize the first frame in the future.
You need a crbug for this. There is a potential for an unexpected deadlock here.
 For example, If the main thread is waiting on a spinlock (possibly implemented
on top a SharedArrayBuffer) that is to be unlocked by a worker after commit(),
the browser should not hang.

https://codereview.chromium.org/2376743002/diff/100001/third_party/WebKit/Sou...
File
third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.h
(right):

https://codereview.chromium.org/2376743002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.h:53:
void setTransferableResourceCase1(cc::TransferableResource&,
These function names have readability issues. You could call them ...InMemory,
...InTexture and ...MemoryToTexture. Or something like that.

[xidachen, 2016-10-04 14:43:06]

https://codereview.chromium.org/2376743002/diff/100001/third_party/WebKit/Sou...
File
third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp
(right):

https://codereview.chromium.org/2376743002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp:90:
// Try to optimize the first frame in the future.
On 2016/10/04 14:20:48, Justin Novosad wrote:
> You need a crbug for this. There is a potential for an unexpected deadlock
here.
>  For example, If the main thread is waiting on a spinlock (possibly
implemented
> on top a SharedArrayBuffer) that is to be unlocked by a worker after commit(),
> the browser should not hang.

Done.

https://codereview.chromium.org/2376743002/diff/100001/third_party/WebKit/Sou...
File
third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.h
(right):

https://codereview.chromium.org/2376743002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.h:53:
void setTransferableResourceCase1(cc::TransferableResource&,
On 2016/10/04 14:20:48, Justin Novosad wrote:
> These function names have readability issues. You could call them ...InMemory,
> ...InTexture and ...MemoryToTexture. Or something like that.

Done.

[Justin Novosad, 2016-10-04 15:01:58]

lgtm

[Justin Novosad, 2016-10-04 15:02:58]

https://codereview.chromium.org/2376743002/diff/120001/third_party/WebKit/Sou...
File
third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp
(right):

https://codereview.chromium.org/2376743002/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp:56:
void OffscreenCanvasFrameDispatcherImpl::setTransferableResourceCase1(
You forgot to rename here

[xidachen, 2016-10-04 15:14:36]

The CQ bit was checked by xidachen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 15:14:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xidachen, 2016-10-04 16:12:55]

The CQ bit was unchecked by xidachen@chromium.org

[xidachen, 2016-10-04 16:53:11]

The CQ bit was checked by xidachen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 16:53:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xidachen, 2016-10-04 17:42:16]

Description was changed from

==========
Implement commit for unaccelerated canvas with GPU compositing

This CL implements OffscreenCanvas2d's commit API in the case where the
canvas is not GPU-accelerated, but the compositor is. In this case, we
extract a StaticBitmapImage from the imageBuffer, upload the CPU memory
that the StaticBitmapImage holds to GPU texture, and prepare a
CompositorFrame from the GPU texture.

A GPU pixel test is added to test this code path.

BUG=563852
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
Implement commit for unaccelerated canvas with GPU compositing

This CL implements OffscreenCanvas2d's commit API in the case where the
canvas is not GPU-accelerated, but the compositor is. In this case, we
extract a StaticBitmapImage from the imageBuffer, upload the CPU memory
that the StaticBitmapImage holds to GPU texture, and prepare a
CompositorFrame from the GPU texture.

A GPU pixel test is added to test this code path.

BUG=563852
TBR=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[xidachen, 2016-10-04 17:54:42]

xidachen@chromium.org changed reviewers:
- kbr@chromium.org

[xidachen, 2016-10-04 18:13:55]

The CQ bit was unchecked by xidachen@chromium.org

[xidachen, 2016-10-04 18:14:02]

The CQ bit was checked by xidachen@chromium.org

[xidachen, 2016-10-04 18:14:02]

The patchset sent to the CQ was uploaded after l-g-t-m from junov@chromium.org
Link to the patchset: https://codereview.chromium.org/2376743002/#ps160001
(title: "fix windbg compile error")

[commit-bot: I haz the power, 2016-10-04 18:14:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 21:04:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 21:04:05]

Failed to apply the patch.
On branch working_branch
Your branch is up-to-date with 'origin/refs/pending/heads/master'.
nothing to commit, working tree clean

[commit-bot: I haz the power, 2016-10-04 21:04:31]

Description was changed from

==========
Implement commit for unaccelerated canvas with GPU compositing

This CL implements OffscreenCanvas2d's commit API in the case where the
canvas is not GPU-accelerated, but the compositor is. In this case, we
extract a StaticBitmapImage from the imageBuffer, upload the CPU memory
that the StaticBitmapImage holds to GPU texture, and prepare a
CompositorFrame from the GPU texture.

A GPU pixel test is added to test this code path.

BUG=563852
TBR=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
Implement commit for unaccelerated canvas with GPU compositing

This CL implements OffscreenCanvas2d's commit API in the case where the
canvas is not GPU-accelerated, but the compositor is. In this case, we
extract a StaticBitmapImage from the imageBuffer, upload the CPU memory
that the StaticBitmapImage holds to GPU texture, and prepare a
CompositorFrame from the GPU texture.

A GPU pixel test is added to test this code path.

BUG=563852
TBR=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Committed: https://crrev.com/5371a41d019eb15db652d406a7c0f63ea179cbbe
Cr-Commit-Position: refs/heads/master@{#422927}
==========

[commit-bot: I haz the power, 2016-10-04 21:04:32]

Patchset 9 (id:??) landed as
https://crrev.com/5371a41d019eb15db652d406a7c0f63ea179cbbe
Cr-Commit-Position: refs/heads/master@{#422927}

[Ken Russell (switch to Gerrit), 2016-10-05 00:06:23]

kbr@chromium.org changed reviewers:
+ kbr@chromium.org

[Ken Russell (switch to Gerrit), 2016-10-05 00:06:24]

LGTM after the fact.

https://codereview.chromium.org/2376743002/diff/160001/content/test/gpu/gpu_t...
File content/test/gpu/gpu_tests/pixel_expectations.py (right):

https://codereview.chromium.org/2376743002/diff/160001/content/test/gpu/gpu_t...
content/test/gpu/gpu_tests/pixel_expectations.py:38:
self.Fail('Pixel_OffscreenCanvasUnaccelerated2DGPUCompositingWorker',
bug=563858)
>80 cols

[xidachen, 2016-10-05 00:07:46]

On 2016/10/05 00:06:24, Ken Russell wrote:
> LGTM after the fact.
> 
>
https://codereview.chromium.org/2376743002/diff/160001/content/test/gpu/gpu_t...
> File content/test/gpu/gpu_tests/pixel_expectations.py (right):
> 
>
https://codereview.chromium.org/2376743002/diff/160001/content/test/gpu/gpu_t...
> content/test/gpu/gpu_tests/pixel_expectations.py:38:
> self.Fail('Pixel_OffscreenCanvasUnaccelerated2DGPUCompositingWorker',
> bug=563858)
> >80 cols

Thanks Ken. I am watching the bots now, will remove these failure entries once
all reference images are generated.