Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 2376693002: Remove call to MessageLoop::QuitWhenIdle() in network_time_tracker.cc. (Closed)

Created:
4 years, 2 months ago by fdoray
Modified:
4 years, 2 months ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove call to MessageLoop::QuitWhenIdle() in network_time_tracker.cc. MessageLoop::QuitWhenIdle() is deprecated. RunLoop should be used instead. BUG=616447 Committed: https://crrev.com/b254e0eeb34a51af29409b7cd3abae5d06f37148 Cr-Commit-Position: refs/heads/master@{#421251}

Patch Set 1 #

Patch Set 2 : self-review #

Patch Set 3 : self-review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M components/network_time/network_time_tracker.h View 1 2 chunks +4 lines, -2 lines 0 comments Download
M components/network_time/network_time_tracker.cc View 1 2 4 chunks +6 lines, -8 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
fdoray
PTAL
4 years, 2 months ago (2016-09-27 14:07:51 UTC) #6
Nicolas Zea
lgtm
4 years, 2 months ago (2016-09-27 17:26:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2376693002/40001
4 years, 2 months ago (2016-09-27 17:27:10 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-09-27 17:33:25 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 17:36:44 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b254e0eeb34a51af29409b7cd3abae5d06f37148
Cr-Commit-Position: refs/heads/master@{#421251}

Powered by Google App Engine
This is Rietveld 408576698