Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Unified Diff: components/network_time/network_time_tracker.h

Issue 2376693002: Remove call to MessageLoop::QuitWhenIdle() in network_time_tracker.cc. (Closed)
Patch Set: self-review Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/network_time/network_time_tracker.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/network_time/network_time_tracker.h
diff --git a/components/network_time/network_time_tracker.h b/components/network_time/network_time_tracker.h
index 5e06fa6e58b0743b8b9a3710b3a030658a098554..7faf1fdb1841709016a5ce00171e329d1766b58c 100644
--- a/components/network_time/network_time_tracker.h
+++ b/components/network_time/network_time_tracker.h
@@ -22,7 +22,7 @@ class PrefRegistrySimple;
class PrefService;
namespace base {
-class MessageLoop;
+class RunLoop;
class TickClock;
} // namespace base
@@ -144,7 +144,9 @@ class NetworkTimeTracker : public net::URLFetcherDelegate {
std::unique_ptr<net::URLFetcher> time_fetcher_;
base::TimeTicks fetch_started_;
std::unique_ptr<client_update_protocol::Ecdsa> query_signer_;
- base::MessageLoop* loop_; // For testing; quit on fetch complete.
+
+ // Run by WaitForFetchForTesting() and quit by OnURLFetchComplete().
+ base::RunLoop* run_loop_for_testing_ = nullptr;
// The |Clock| and |TickClock| are used to sanity-check one another, allowing
// the NetworkTimeTracker to notice e.g. suspend/resume events and clock
« no previous file with comments | « no previous file | components/network_time/network_time_tracker.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698