Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Unified Diff: build/common.gypi

Issue 237663003: Make resource repacker work on Windows (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/resources/find_used_resources.py » ('j') | tools/resources/find_used_resources.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 8e48115a01d20f9fe91015a39b49b502f36dc59e..0eaf2c7a6c253899b945dcbe4e5168ef83b3fcfb 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -1911,9 +1911,12 @@
['notifications==1', {
'grit_defines': ['-D', 'enable_notifications'],
}],
- ['enable_resource_whitelist_generation==1', {
+ ['enable_resource_whitelist_generation==1 and OS!="win"', {
scottmg 2014/04/14 23:35:26 I guess we might want a clang==0 in here, but sinc
'grit_rc_header_format': ['-h', '#define {textual_id} _Pragma("whitelisted_resource_{numeric_id}") {numeric_id}'],
}],
+ ['enable_resource_whitelist_generation==1 and OS=="win"', {
+ 'grit_rc_header_format': ['-h', '#define {textual_id} __pragma(message("whitelisted_resource_{numeric_id}")) {numeric_id}'],
+ }],
['enable_mdns==1 or OS=="mac"', {
'grit_defines': ['-D', 'enable_service_discovery'],
'enable_service_discovery%': 1
« no previous file with comments | « no previous file | tools/resources/find_used_resources.py » ('j') | tools/resources/find_used_resources.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698