Chromium Code Reviews| Index: tools/resources/find_used_resources.py |
| diff --git a/tools/resources/find_used_resources.py b/tools/resources/find_used_resources.py |
| index 3fc3bcef33920ab2188e2fa28e9702cc7a06be66..adce50e79d0e21c6dfddd19376e8f11543b523bc 100755 |
| --- a/tools/resources/find_used_resources.py |
| +++ b/tools/resources/find_used_resources.py |
| @@ -21,6 +21,8 @@ to print out a UnknownPragma message every time a resource id is used. E.g.: |
| foo.cc:22:0: warning: ignoring #pragma whitelisted_resource_12345 |
| [-Wunknown-pragmas] |
| +On Windows, the message is simply a message via __pragma(message(...)). |
|
Nico
2014/04/14 23:42:00
Hm, I wonder if we could do the same on non-win:
scottmg
2014/04/14 23:45:20
From the chromium-dev thread titled "generated_res
aurimas (slooooooooow)
2014/04/14 23:53:05
pragma message is not supported on gcc used to bui
|
| + |
| """ |
| @@ -29,8 +31,8 @@ def GetResourceIdsInPragmaWarnings(input): |
| for the given input. |
| """ |
| used_resources = set() |
| - unknown_pragma_warning_pattern = re.compile('warning: ignoring #pragma ' |
| - 'whitelisted_resource_(?P<resource_id>[0-9]*) \[-Wunknown-pragmas\]') |
| + unknown_pragma_warning_pattern = re.compile( |
| + 'whitelisted_resource_(?P<resource_id>[0-9]*)') |
| for ln in input: |
| match = unknown_pragma_warning_pattern.search(ln) |
| if match: |