Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 2376573002: Cleanup blimp/client/core code organization. (Closed)

Created:
4 years, 2 months ago by nyquist
Modified:
4 years, 2 months ago
CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, steimel+watch-blimp_chromium.org, gcasto+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, perumaal+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, agrieve+watch_chromium.org, dtrainor+watch-blimp_chromium.org, scf+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup blimp/client/core code organization. The //blimp/client/core directory had some files that were located directly there without being in a sub-directory. This ended up being confusing for other developers, so this CL cleans this up by adding a //blimp/client/core/context directory. It also creates a directory for the switches. This CL also temporarily adds a common directory that both the context classes and other code can depend on. That in turn can then of course not depend on anything else in //blimp/client/core. Lastly, it also cleans up the //blimp/client/core/settings directory to now contain the Java-files it refers to. In addition, the documentation is updated to include information about this change, plus add information about the relatively new support directory. BUG=647848 Committed: https://crrev.com/5026f9cb132373a27d9660d8beab832dc90d7184 Cr-Commit-Position: refs/heads/master@{#421968}

Patch Set 1 #

Patch Set 2 : Rebased #

Total comments: 2

Patch Set 3 : Addressed nit from dtrainor #

Patch Set 4 : merged origin/master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+262 lines, -1796 lines) Patch
M blimp/client/BUILD.gn View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M blimp/client/README.md View 6 chunks +18 lines, -7 lines 0 comments Download
M blimp/client/app/android/javatests/src/org/chromium/blimp/core/settings/BlimpPreferencesTest.java View 1 1 chunk +1 line, -0 lines 0 comments Download
M blimp/client/core/BUILD.gn View 1 2 3 2 chunks +10 lines, -144 lines 0 comments Download
D blimp/client/core/android/blimp_client_context_impl_android.h View 1 2 3 1 chunk +0 lines, -70 lines 0 comments Download
D blimp/client/core/android/blimp_client_context_impl_android.cc View 1 2 3 1 chunk +0 lines, -126 lines 0 comments Download
D blimp/client/core/android/blimp_jni_registrar.cc View 1 chunk +0 lines, -35 lines 0 comments Download
D blimp/client/core/android/dummy_blimp_client_context_android.h View 1 chunk +0 lines, -37 lines 0 comments Download
D blimp/client/core/android/dummy_blimp_client_context_android.cc View 1 chunk +0 lines, -54 lines 0 comments Download
D blimp/client/core/android/dummy_blimp_jni_registrar.cc View 1 chunk +0 lines, -21 lines 0 comments Download
D blimp/client/core/android/java/src/org/chromium/blimp/core/BlimpClientContextImpl.java View 1 2 3 1 chunk +0 lines, -130 lines 0 comments Download
D blimp/client/core/android/java/src/org/chromium/blimp/core/BlimpClientSwitches.java View 1 chunk +0 lines, -23 lines 0 comments Download
D blimp/client/core/android/java/src/org/chromium/blimp/core/DummyBlimpClientContext.java View 1 2 3 1 chunk +0 lines, -77 lines 0 comments Download
D blimp/client/core/android/java/src/org/chromium/blimp/core/settings/AboutBlimpPreferences.java View 1 1 chunk +0 lines, -304 lines 0 comments Download
D blimp/client/core/android/java/src/org/chromium/blimp/core/settings/BlimpPreferencesDelegate.java View 1 chunk +0 lines, -29 lines 0 comments Download
D blimp/client/core/android/java/src/org/chromium/blimp/core/settings/PreferencesUtil.java View 1 2 3 1 chunk +0 lines, -44 lines 0 comments Download
D blimp/client/core/blimp_client_context_impl.h View 1 2 3 1 chunk +0 lines, -149 lines 0 comments Download
D blimp/client/core/blimp_client_context_impl.cc View 1 2 3 1 chunk +0 lines, -258 lines 0 comments Download
D blimp/client/core/blimp_client_context_impl_unittest.cc View 1 chunk +0 lines, -84 lines 0 comments Download
D blimp/client/core/blimp_client_switches.h View 1 chunk +0 lines, -39 lines 0 comments Download
D blimp/client/core/blimp_client_switches.cc View 1 chunk +0 lines, -25 lines 0 comments Download
A blimp/client/core/common/BUILD.gn View 1 chunk +21 lines, -0 lines 0 comments Download
A blimp/client/core/common/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
A + blimp/client/core/common/android/java/src/org/chromium/blimp/core/common/PreferencesUtil.java View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A blimp/client/core/context/BUILD.gn View 1 2 3 1 chunk +137 lines, -0 lines 0 comments Download
A + blimp/client/core/context/android/blimp_client_context_impl_android.h View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
A + blimp/client/core/context/android/blimp_client_context_impl_android.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + blimp/client/core/context/android/blimp_jni_registrar.cc View 1 chunk +1 line, -1 line 0 comments Download
A + blimp/client/core/context/android/dummy_blimp_client_context_android.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + blimp/client/core/context/android/dummy_blimp_client_context_android.cc View 1 chunk +1 line, -1 line 0 comments Download
A + blimp/client/core/context/android/dummy_blimp_jni_registrar.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/core/context/android/java/src/org/chromium/blimp/core/BlimpClientContextImpl.java View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + blimp/client/core/context/android/java/src/org/chromium/blimp/core/DummyBlimpClientContext.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/core/context/blimp_client_context_impl.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
A + blimp/client/core/context/blimp_client_context_impl.cc View 1 2 3 4 chunks +3 lines, -3 lines 0 comments Download
A + blimp/client/core/context/blimp_client_context_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + blimp/client/core/context/dummy_blimp_client_context.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + blimp/client/core/context/dummy_blimp_client_context.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D blimp/client/core/dummy_blimp_client_context.h View 1 chunk +0 lines, -38 lines 0 comments Download
D blimp/client/core/dummy_blimp_client_context.cc View 1 chunk +0 lines, -60 lines 0 comments Download
M blimp/client/core/session/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M blimp/client/core/session/assignment_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M blimp/client/core/session/assignment_source_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M blimp/client/core/session/identity_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M blimp/client/core/settings/BUILD.gn View 1 2 chunks +4 lines, -4 lines 0 comments Download
A + blimp/client/core/settings/android/java/src/org/chromium/blimp/core/settings/AboutBlimpPreferences.java View 1 1 chunk +1 line, -0 lines 0 comments Download
A + blimp/client/core/settings/android/java/src/org/chromium/blimp/core/settings/BlimpPreferencesDelegate.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A blimp/client/core/switches/BUILD.gn View 1 chunk +29 lines, -0 lines 0 comments Download
A + blimp/client/core/switches/android/java/src/org/chromium/blimp/core/BlimpClientSwitches.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/core/switches/blimp_client_switches.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + blimp/client/core/switches/blimp_client_switches.cc View 1 chunk +1 line, -1 line 0 comments Download
M blimp/client/session/blimp_client_session.cc View 2 chunks +1 line, -1 line 0 comments Download
M blimp/engine/BUILD.gn View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M blimp/engine/browser_tests/blimp_browser_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M blimp/engine/browser_tests/navigation_browsertest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (13 generated)
nyquist
dtrainor: PTAL
4 years, 2 months ago (2016-09-27 06:54:46 UTC) #8
David Trainor- moved to gerrit
lgtm % one nit! https://codereview.chromium.org/2376573002/diff/20001/blimp/client/core/context/BUILD.gn File blimp/client/core/context/BUILD.gn (right): https://codereview.chromium.org/2376573002/diff/20001/blimp/client/core/context/BUILD.gn#newcode47 blimp/client/core/context/BUILD.gn:47: source_set("dummy_context") { "dummy" might be ...
4 years, 2 months ago (2016-09-29 20:03:51 UTC) #12
nyquist
https://codereview.chromium.org/2376573002/diff/20001/blimp/client/core/context/BUILD.gn File blimp/client/core/context/BUILD.gn (right): https://codereview.chromium.org/2376573002/diff/20001/blimp/client/core/context/BUILD.gn#newcode47 blimp/client/core/context/BUILD.gn:47: source_set("dummy_context") { On 2016/09/29 20:03:51, David Trainor wrote: > ...
4 years, 2 months ago (2016-09-29 21:48:24 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2376573002/60001
4 years, 2 months ago (2016-09-29 21:48:51 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 2 months ago (2016-09-29 22:57:38 UTC) #17
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 23:01:31 UTC) #19
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/5026f9cb132373a27d9660d8beab832dc90d7184
Cr-Commit-Position: refs/heads/master@{#421968}

Powered by Google App Engine
This is Rietveld 408576698