Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Side by Side Diff: blimp/client/core/BUILD.gn

Issue 2376573002: Cleanup blimp/client/core code organization. (Closed)
Patch Set: merged origin/master Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 if (is_android) { 5 if (is_android) {
6 import("//build/config/android/config.gni") 6 import("//build/config/android/config.gni")
7 import("//build/config/android/rules.gni") 7 import("//build/config/android/rules.gni")
8 } 8 }
9 9
10 import("//blimp/client/core/config.gni") 10 import("//blimp/client/core/config.gni")
(...skipping 15 matching lines...) Expand all
26 } 26 }
27 } 27 }
28 28
29 group("core") { 29 group("core") {
30 visibility = [ 30 visibility = [
31 "//blimp/client/*", 31 "//blimp/client/*",
32 "//blimp/test/*", 32 "//blimp/test/*",
33 ] 33 ]
34 34
35 deps = [ 35 deps = [
36 ":context",
37 ":switches",
38 "//blimp/client/core/compositor", 36 "//blimp/client/core/compositor",
39 "//blimp/client/core/contents", 37 "//blimp/client/core/contents",
38 "//blimp/client/core/context",
40 "//blimp/client/core/feedback", 39 "//blimp/client/core/feedback",
41 "//blimp/client/core/geolocation", 40 "//blimp/client/core/geolocation",
42 "//blimp/client/core/render_widget", 41 "//blimp/client/core/render_widget",
43 "//blimp/client/core/session", 42 "//blimp/client/core/session",
44 "//blimp/client/core/settings", 43 "//blimp/client/core/settings",
44 "//blimp/client/core/switches",
45 ] 45 ]
46 } 46 }
47 47
48 source_set("dummy_core") { 48 group("dummy_core") {
49 visibility = [ ":*" ] 49 visibility = [ ":*" ]
50 50
51 sources = [ 51 deps = [
52 "dummy_blimp_client_context.cc", 52 "//blimp/client/core/context:dummy",
53 "dummy_blimp_client_context.h",
54 ] 53 ]
54 }
55
56 group("unit_tests") {
57 testonly = true
55 58
56 deps = [ 59 deps = [
57 "//base",
58 "//blimp/client/public:public_headers",
59 "//url",
60 ]
61
62 if (is_android) {
63 sources += [
64 "android/dummy_blimp_client_context_android.cc",
65 "android/dummy_blimp_client_context_android.h",
66 "android/dummy_blimp_jni_registrar.cc",
67 ]
68
69 deps += [ ":dummy_core_jni_headers" ]
70 }
71 }
72
73 source_set("unit_tests") {
74 testonly = true
75
76 sources = [
77 "blimp_client_context_impl_unittest.cc",
78 ]
79
80 deps = [
81 ":context",
82 "//blimp/client/core/compositor:unit_tests", 60 "//blimp/client/core/compositor:unit_tests",
83 "//blimp/client/core/contents:unit_tests", 61 "//blimp/client/core/contents:unit_tests",
62 "//blimp/client/core/context:unit_tests",
84 "//blimp/client/core/feedback:unit_tests", 63 "//blimp/client/core/feedback:unit_tests",
85 "//blimp/client/core/geolocation:unit_tests", 64 "//blimp/client/core/geolocation:unit_tests",
86 "//blimp/client/core/render_widget:unit_tests", 65 "//blimp/client/core/render_widget:unit_tests",
87 "//blimp/client/core/session:unit_tests", 66 "//blimp/client/core/session:unit_tests",
88 "//blimp/client/public:public_headers",
89 "//blimp/client/test",
90 "//testing/gmock",
91 "//testing/gtest",
92 ] 67 ]
93 } 68 }
94 69
95 source_set("context") {
96 sources = [
97 "blimp_client_context_impl.cc",
98 "blimp_client_context_impl.h",
99 ]
100
101 public_deps = [
102 "//base",
103 "//blimp/client/core/compositor:compositor",
104 "//blimp/client/core/contents",
105 "//blimp/client/core/session",
106 "//blimp/client/public:public_headers",
107 "//device/geolocation",
108 "//url",
109 ]
110
111 deps = [
112 ":switches",
113 "//blimp/client/core/feedback",
114 "//blimp/client/core/geolocation",
115 "//blimp/client/core/settings",
116 ]
117
118 if (is_android) {
119 sources += [
120 "android/blimp_client_context_impl_android.cc",
121 "android/blimp_client_context_impl_android.h",
122 "android/blimp_jni_registrar.cc",
123 ]
124
125 deps += [
126 ":context_jni_headers",
127 "//blimp/client/core/settings",
128 "//ui/android",
129 ]
130 }
131 }
132
133 source_set("switches") {
134 visibility = [
135 "//blimp/client/*",
136 "//blimp/engine:browser_tests",
137 ]
138
139 sources = [
140 "blimp_client_switches.cc",
141 "blimp_client_switches.h",
142 ]
143 }
144
145 if (is_android) { 70 if (is_android) {
146 # This target is here to let //chrome depend on 71 # This target is here to let //chrome depend on
147 # //blimp/client/public:public_java and automatically get the correct 72 # //blimp/client/public:public_java and automatically get the correct
148 # implementation of //blimp/client/core depending on whether 73 # implementation of //blimp/client/core depending on whether
149 # enable_blimp_client is set or not. 74 # enable_blimp_client is set or not.
150 java_group("core_shim_java") { 75 java_group("core_shim_java") {
151 visibility = [ "//blimp/client/public/*" ] 76 visibility = [ "//blimp/client/public/*" ]
152 77
153 if (enable_blimp_client) { 78 if (enable_blimp_client) {
154 deps = [ 79 deps = [
155 ":core_java", 80 ":core_java",
156 ] 81 ]
157 } else { 82 } else {
158 deps = [ 83 deps = [
159 ":dummy_core_java", 84 ":dummy_core_java",
160 ] 85 ]
161 } 86 }
162 } 87 }
163 88
164 java_group("core_java") { 89 java_group("core_java") {
165 visibility = [ 90 visibility = [
166 "//blimp/client/*", 91 "//blimp/client/*",
167 "//blimp:blimp_unittests_java_deps", 92 "//blimp:blimp_unittests_java_deps",
168 ] 93 ]
169 94
170 deps = [ 95 deps = [
171 ":context_java",
172 ":switches_java",
173 "//blimp/client/core/contents:contents_java", 96 "//blimp/client/core/contents:contents_java",
97 "//blimp/client/core/context:context_java",
174 "//blimp/client/core/feedback:feedback_java", 98 "//blimp/client/core/feedback:feedback_java",
175 "//blimp/client/core/settings:settings_java", 99 "//blimp/client/core/settings:settings_java",
100 "//blimp/client/core/switches:switches_java",
176 "//device/geolocation:geolocation_java", 101 "//device/geolocation:geolocation_java",
177 ] 102 ]
178 } 103 }
179 104
180 android_library("dummy_core_java") { 105 java_group("dummy_core_java") {
181 visibility = [ ":*" ] 106 visibility = [ ":*" ]
182 107
183 java_files = [ "android/java/src/org/chromium/blimp/core/DummyBlimpClientCon text.java" ]
184
185 deps = [ 108 deps = [
186 "//base:base_java", 109 "//blimp/client/core/context:dummy_context_java",
187 "//blimp/client/public:public_headers_java",
188 "//ui/android:ui_java",
189 ] 110 ]
190 } 111 }
191
192 android_library("context_java") {
193 visibility = [ "//blimp/client/*" ]
194
195 java_files = [ "android/java/src/org/chromium/blimp/core/BlimpClientContextI mpl.java" ]
196
197 deps = [
198 ":common_java",
199 ":switches_java",
200 "//base:base_java",
201 "//blimp/client/core/contents:contents_java",
202 "//blimp/client/core/feedback:feedback_java",
203 "//blimp/client/core/settings:settings_java",
204 "//blimp/client/public:public_headers_java",
205 "//ui/android:ui_java",
206 ]
207 }
208
209 android_library("common_java") {
210 visibility = [ "//blimp/client/*" ]
211
212 java_files = [ "android/java/src/org/chromium/blimp/core/settings/Preference sUtil.java" ]
213
214 deps = [
215 "//base:base_java",
216 "//blimp/client/public:public_headers_java",
217 ]
218 }
219
220 android_library("switches_java") {
221 visibility = [ "//blimp/client/*" ]
222
223 java_files =
224 [ "android/java/src/org/chromium/blimp/core/BlimpClientSwitches.java" ]
225 }
226
227 generate_jni("context_jni_headers") {
228 visibility = [ ":*" ]
229
230 sources = [
231 "android/java/src/org/chromium/blimp/core/BlimpClientContextImpl.java",
232 ]
233
234 jni_package = "blimp/client/core"
235 }
236
237 generate_jni("dummy_core_jni_headers") {
238 visibility = [ ":*" ]
239
240 sources = [
241 "android/java/src/org/chromium/blimp/core/DummyBlimpClientContext.java",
242 ]
243
244 jni_package = "blimp/client/core"
245 }
246 } 112 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698