Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 2376493002: Catch exceptions while preparing analysis.implemented notification. (Closed)

Created:
4 years, 2 months ago by scheglov
Modified:
4 years, 2 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Catch exceptions while preparing analysis.implemented notification. This notification is sent often, and uses index and search engine. We have several exceptions in internal logs, and all there exceptions are fatal by default. It seems too harsh to shutdown the server because of a missing notification. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/ef015221b1cf6ed345f5fae22f65ef6d2096f702

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -6 lines) Patch
M pkg/analysis_server/lib/src/operation/operation_analysis.dart View 1 chunk +13 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 2 months ago (2016-09-26 19:24:43 UTC) #1
Brian Wilkerson
lgtm
4 years, 2 months ago (2016-09-26 19:34:11 UTC) #2
scheglov
4 years, 2 months ago (2016-09-26 19:54:39 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ef015221b1cf6ed345f5fae22f65ef6d2096f702 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698