Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(690)

Unified Diff: pkg/analysis_server/lib/src/operation/operation_analysis.dart

Issue 2376493002: Catch exceptions while preparing analysis.implemented notification. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/operation/operation_analysis.dart
diff --git a/pkg/analysis_server/lib/src/operation/operation_analysis.dart b/pkg/analysis_server/lib/src/operation/operation_analysis.dart
index 634ae5456e0b73e267ce44242194ed055a3ed0d4..dd72b4915fcbca0be90d16ed4ed303aa033c03b0 100644
--- a/pkg/analysis_server/lib/src/operation/operation_analysis.dart
+++ b/pkg/analysis_server/lib/src/operation/operation_analysis.dart
@@ -48,12 +48,19 @@ scheduleImplementedNotification(
for (String file in files) {
CompilationUnitElement unitElement = server.getCompilationUnitElement(file);
if (unitElement != null) {
- ImplementedComputer computer =
- new ImplementedComputer(searchEngine, unitElement);
- await computer.compute();
- var params = new protocol.AnalysisImplementedParams(
- file, computer.classes, computer.members);
- server.sendNotification(params.toNotification());
+ try {
+ ImplementedComputer computer =
+ new ImplementedComputer(searchEngine, unitElement);
+ await computer.compute();
+ var params = new protocol.AnalysisImplementedParams(
+ file, computer.classes, computer.members);
+ server.sendNotification(params.toNotification());
+ } catch (exception, stackTrace) {
+ server.sendServerErrorNotification(
+ 'Failed to send analysis.implemented notification.',
+ exception,
+ stackTrace);
+ }
}
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698