Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2376483002: Initialize properly availableHeight in computePercentageLogicalHeight (Closed)

Created:
4 years, 2 months ago by Manuel Rego
Modified:
4 years, 2 months ago
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Initialize properly availableHeight in computePercentageLogicalHeight In r648880 we introduced a regression because of the new implementation of LayoutBox::computePercentageLogicalHeight() was wrongly initializing as 0 the availableHeight variable. We should just use -1 like the code was doing before that patch. BUG=648880 TEST=fast/table/quirks-mode-percent-height.html Committed: https://crrev.com/5b0f27ec040f501eb7af22ea017db9f4f0c902dd Cr-Commit-Position: refs/heads/master@{#421145}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/fast/table/quirks-mode-percent-height.html View 1 chunk +11 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/table/quirks-mode-percent-height-expected.html View 1 chunk +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Manuel Rego
4 years, 2 months ago (2016-09-26 19:35:47 UTC) #2
cbiesinger
lgtm
4 years, 2 months ago (2016-09-26 20:44:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2376483002/1
4 years, 2 months ago (2016-09-27 06:52:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-27 08:08:11 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 08:10:01 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5b0f27ec040f501eb7af22ea017db9f4f0c902dd
Cr-Commit-Position: refs/heads/master@{#421145}

Powered by Google App Engine
This is Rietveld 408576698