third_party/WebKit/Source/core/layout/LayoutBox.cpp - Issue 2376483002: Initialize properly availableHeight in computePercentageLogicalHeight

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 2376483002: Initialize properly availableHeight in computePercentageLogicalHeight (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutBox.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.cpp b/third_party/WebKit/Source/core/layout/LayoutBox.cpp

index 2f0c98f78df8b94055def04cbc67dc3db7bdd15f..d2214743dc36a06ebe1d13de49223450a4f2e287 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBox.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutBox.cpp

@@ -2839,7 +2839,7 @@ LayoutUnit LayoutBox::computePercentageLogicalHeight(const Length& height) const

}

cb->addPercentHeightDescendant(const_cast<LayoutBox*>(this));

- LayoutUnit availableHeight;

+ LayoutUnit availableHeight(-1);

if (isHorizontalWritingMode() != cb->isHorizontalWritingMode()) {

availableHeight = containingBlockChild->containingBlockLogicalWidthForContent();

} else if (hasOverrideContainingBlockLogicalHeight()) {

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/table/quirks-mode-percent-height-expected.html ('k') | no next file » | no next file with comments »