Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1551)

Issue 2376453003: Remove old, unused per-plugin data from user prefs

Created:
4 years, 2 months ago by raymes
Modified:
3 years, 11 months ago
Reviewers:
msramek, Bernhard Bauer
CC:
chromium-reviews, markusheintz_, msramek+watch_chromium.org, raymes+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove old, unused per-plugin data from user prefs There is no longer a way for users to set per-plugin prefs (they can still be set by other means, such as extensions). Clear this data from user prefs. BUG=615738

Patch Set 1 #

Patch Set 2 : Remove old, unused per-plugin data from user prefs #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -108 lines) Patch
M chrome/browser/content_settings/content_settings_pref_provider_unittest.cc View 1 1 chunk +53 lines, -27 lines 0 comments Download
M components/content_settings/core/browser/content_settings_pref.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/content_settings/core/browser/content_settings_pref.cc View 14 chunks +36 lines, -80 lines 3 comments Download

Messages

Total messages: 7 (1 generated)
raymes
4 years, 2 months ago (2016-09-27 01:27:16 UTC) #2
Bernhard Bauer
lgtm https://codereview.chromium.org/2376453003/diff/20001/components/content_settings/core/browser/content_settings_pref.cc File components/content_settings/core/browser/content_settings_pref.cc (right): https://codereview.chromium.org/2376453003/diff/20001/components/content_settings/core/browser/content_settings_pref.cc#newcode259 components/content_settings/core/browser/content_settings_pref.cc:259: // Careful: The returned value could be nullptr ...
4 years, 2 months ago (2016-09-27 09:34:44 UTC) #3
msramek
Sorry, not LGTM just yet, unless I'm missing something. I checked out the tip of ...
4 years, 2 months ago (2016-09-27 11:56:15 UTC) #4
raymes
> I checked out the tip of the tree and the chrome://plugins page has not ...
4 years, 2 months ago (2016-09-27 23:45:10 UTC) #5
msramek
As per https://codereview.chromium.org/2630443002/, I guess I can unblock this? LGTM.
3 years, 11 months ago (2017-01-12 23:54:36 UTC) #6
msramek
3 years, 11 months ago (2017-01-12 23:56:07 UTC) #7
https://codereview.chromium.org/2376453003/diff/20001/components/content_sett...
File components/content_settings/core/browser/content_settings_pref.cc (right):

https://codereview.chromium.org/2376453003/diff/20001/components/content_sett...
components/content_settings/core/browser/content_settings_pref.cc:300: //
TODO(raymes): delete this code ~M57.
A lot of time has passed, so please update this :)

Powered by Google App Engine
This is Rietveld 408576698