Remove old, unused per-plugin data from user prefs

chrome/browser/content_settings/content_settings_pref_provider_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/content_settings/core/browser/content_settings_pref_provider.h"
 
 #include <memory>
 
 #include "base/auto_reset.h"
 #include "base/command_line.h"
@@ skipping 275 matching lines @@
       new base::FundamentalValue(CONTENT_SETTING_BLOCK));
   EXPECT_EQ(CONTENT_SETTING_BLOCK,
             TestUtils::GetContentSetting(&pref_content_settings_provider, host4,
                                          host4, CONTENT_SETTINGS_TYPE_COOKIES,
                                          std::string(), false));
 
   pref_content_settings_provider.ShutdownOnUIThread();
 }
 
 #if defined(ENABLE_PLUGINS)
-TEST_F(PrefProviderTest, ResourceIdentifier) {
+// Old per-plugin pref settings should be deleted when reading settings.
+TEST_F(PrefProviderTest, DeprecateResourceIdentifierPrefs) {
   TestingProfile testing_profile;
-  PrefProvider pref_content_settings_provider(testing_profile.GetPrefs(),
-                                              false);
+  PrefService* prefs = testing_profile.GetPrefs();
 
-  GURL host("http://example.com/");
-  ContentSettingsPattern pattern =
-      ContentSettingsPattern::FromString("[*.]example.com");
-  std::string resource1("someplugin");
-  std::string resource2("otherplugin");
+  std::string pref_name =
+      content_settings::WebsiteSettingsRegistry::GetInstance()
+          ->Get(CONTENT_SETTINGS_TYPE_PLUGINS)
+          ->pref_name();
 
-  EXPECT_EQ(CONTENT_SETTING_DEFAULT,
-            TestUtils::GetContentSetting(&pref_content_settings_provider, host,
-                                         host, CONTENT_SETTINGS_TYPE_PLUGINS,
-                                         resource1, false));
-  pref_content_settings_provider.SetWebsiteSetting(
-      pattern,
-      pattern,
-      CONTENT_SETTINGS_TYPE_PLUGINS,
-      resource1,
-      new base::FundamentalValue(CONTENT_SETTING_BLOCK));
-  EXPECT_EQ(CONTENT_SETTING_BLOCK,
-            TestUtils::GetContentSetting(&pref_content_settings_provider, host,
-                                         host, CONTENT_SETTINGS_TYPE_PLUGINS,
-                                         resource1, false));
-  EXPECT_EQ(CONTENT_SETTING_DEFAULT,
-            TestUtils::GetContentSetting(&pref_content_settings_provider, host,
-                                         host, CONTENT_SETTINGS_TYPE_PLUGINS,
-                                         resource2, false));
+  // Set an old per-plugin setting.
+  {
+    DictionaryPrefUpdate update(prefs, pref_name);
+    base::DictionaryValue* all_settings_dictionary = update.Get();
 
-  pref_content_settings_provider.ShutdownOnUIThread();
+    base::DictionaryValue* per_resource_dictionary = new base::DictionaryValue;
+    per_resource_dictionary->SetIntegerWithoutPathExpansion(
+        "plugin_name", CONTENT_SETTING_ALLOW);
+    base::DictionaryValue* settings_dictionary = new base::DictionaryValue;
+    settings_dictionary->SetWithoutPathExpansion("per_resource",
+                                                 per_resource_dictionary);
+
+    base::DictionaryValue* settings_dictionary2 =
+        settings_dictionary->DeepCopy();
+    settings_dictionary2->SetIntegerWithoutPathExpansion("setting",
+                                                         CONTENT_SETTING_ALLOW);
+
+    // This only has a per-plugin setting.
+    all_settings_dictionary->SetWithoutPathExpansion("[*.]test.com,*",
+                                                     settings_dictionary);
+
+    // This has a per-plugin setting and a per-site setting.
+    all_settings_dictionary->SetWithoutPathExpansion("[*.]test2.com,*",
+                                                     settings_dictionary2);
+  }
+
+  // Create the pref-provider.
+  PrefProvider pref_content_settings_provider(prefs, false);
+
+  const base::DictionaryValue* all_settings_dictionary =
+      prefs->GetDictionary(pref_name);
+
+  // The pref that only had the per-plugin setting should be gone.
+  const base::DictionaryValue* result;
+  EXPECT_FALSE(all_settings_dictionary->GetDictionaryWithoutPathExpansion(
+      "[*.]test.com,*", &result));
+
+  // The pref that had the per-site setting should still be there, but the
+  // per-plugin part should be gone.
+  EXPECT_TRUE(all_settings_dictionary->GetDictionaryWithoutPathExpansion(
+      "[*.]test2.com,*", &result));
+  int setting_result;
+  EXPECT_TRUE(
+      result->GetIntegerWithoutPathExpansion("setting", &setting_result));
+  EXPECT_EQ(CONTENT_SETTING_ALLOW, setting_result);
+  EXPECT_FALSE(
+      result->GetDictionaryWithoutPathExpansion("per_resource", nullptr));
 }
 #endif
 
 // http://crosbug.com/17760
 TEST_F(PrefProviderTest, Deadlock) {
   syncable_prefs::TestingPrefServiceSyncable prefs;
   PrefProvider::RegisterProfilePrefs(prefs.registry());
 
   // Chain of events: a preference changes, |PrefProvider| notices it, and reads
   // and writes the preference. When the preference is written, a notification
@@ skipping 185 matching lines @@
   for (const char* pref : nonempty_prefs) {
     DictionaryPrefUpdate update(&prefs, pref);
     const base::DictionaryValue* dictionary = update.Get();
     EXPECT_EQ(1u, dictionary->size());
   }
 
   provider.ShutdownOnUIThread();
 }
 
 }  // namespace content_settings