Convert RapporRecorder to use mojo.

chrome/browser/rappor_recorder_impl.h

Index: chrome/browser/rappor_recorder_impl.h
diff --git a/chrome/browser/rappor_recorder_impl.h b/chrome/browser/rappor_recorder_impl.h
new file mode 100644
index 0000000000000000000000000000000000000000..fba15bcdac02b1f69fe0d11c21375c9819e6feec
--- /dev/null
+++ b/chrome/browser/rappor_recorder_impl.h
@@ -0,0 +1,25 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_RAPPOR_RECORDER_IMPL_H_
+#define CHROME_BROWSER_RAPPOR_RECORDER_IMPL_H_
+
+#include "chrome/common/rappor_recorder.mojom.h"
+
+class GURL;
+
+class RapporRecorderImpl : public mojom::RapporRecorder {

[sky, 2016/10/06 17:28:44]

Is there a reason not to have this code live in components/rappor? It uses
g_browser_process->rappor_service() to get the rappor_service, but couldn't the
constructor take that?

[sky, 2016/10/06 17:28:44]

Please add a description. Imagine looking at this a year from now. Will you
remember what it does?

[nigeltao1, 2016/10/07 03:30:51]

Done.

[nigeltao1, 2016/10/07 03:30:51]

I moved it to component/rappor, and pass the RapporService* through the
constructor.

+ public:
+  RapporRecorderImpl();
+  ~RapporRecorderImpl() override;
+
+  static void Create(mojom::RapporRecorderRequest request);
+
+ private:
+  void RecordRappor(const std::string& metric,

[sky, 2016/10/06 17:28:44]

Generally we prefix overrides with where they come from, e.g.
// chrome::mojom::RapporRecorder:

(see style guide for more details).

[nigeltao1, 2016/10/07 03:30:52]

Done.

+                    const std::string& sample) override;
+  void RecordRapporURL(const std::string& metric, const GURL& sample) override;
+};

[sky, 2016/10/06 17:28:44]

DISALLOW...

[nigeltao1, 2016/10/07 03:30:51]

Done.

+
+#endif  // CHROME_BROWSER_RAPPOR_RECORDER_IMPL_H_