chrome/browser/rappor_recorder_impl.h - Issue 2376403003: Convert RapporRecorder to use mojo.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/rappor_recorder_impl.h

Issue 2376403003: Convert RapporRecorder to use mojo. (Closed)

Patch Set: Convert RapporRecorder to use mojo. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/chrome_content_browser_manifest_overlay.json ('K') | « chrome/browser/chrome_content_browser_manifest_overlay.json ('k') | chrome/browser/rappor_recorder_impl.cc » ('j') | chrome/browser/rappor_recorder_impl.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_RAPPOR_RECORDER_IMPL_H_

	6 #define CHROME_BROWSER_RAPPOR_RECORDER_IMPL_H_

	7

	8 #include "chrome/common/rappor_recorder.mojom.h"

	9

	10 class GURL;

	11

	12 class RapporRecorderImpl : public mojom::RapporRecorder {
	sky 2016/10/06 17:28:44 Is there a reason not to have this code live in co Is there a reason not to have this code live in components/rappor? It uses g_browser_process->rappor_service() to get the rappor_service, but couldn't the constructor take that? sky 2016/10/06 17:28:44 Please add a description. Imagine looking at this Please add a description. Imagine looking at this a year from now. Will you remember what it does? nigeltao1 2016/10/07 03:30:51 Done. Show quoted text On 2016/10/06 17:28:44, sky wrote: > Please add a description. Imagine looking at this a year from now. Will you > remember what it does? Done. nigeltao1 2016/10/07 03:30:51 I moved it to component/rappor, and pass the Rappo Show quoted text On 2016/10/06 17:28:44, sky wrote: > Is there a reason not to have this code live in components/rappor? It uses > g_browser_process->rappor_service() to get the rappor_service, but couldn't the > constructor take that? I moved it to component/rappor, and pass the RapporService* through the constructor.
	13 public:

	14 RapporRecorderImpl();

	15 ~RapporRecorderImpl() override;

	16

	17 static void Create(mojom::RapporRecorderRequest request);

	18

	19 private:

	20 void RecordRappor(const std::string& metric,
	sky 2016/10/06 17:28:44 Generally we prefix overrides with where they come Generally we prefix overrides with where they come from, e.g. // chrome::mojom::RapporRecorder: (see style guide for more details). nigeltao1 2016/10/07 03:30:52 Done. Show quoted text On 2016/10/06 17:28:44, sky wrote: > Generally we prefix overrides with where they come from, e.g. > // chrome::mojom::RapporRecorder: > > (see style guide for more details). Done.
	21 const std::string& sample) override;

	22 void RecordRapporURL(const std::string& metric, const GURL& sample) override;

	23 };
	sky 2016/10/06 17:28:44 DISALLOW... DISALLOW... nigeltao1 2016/10/07 03:30:51 Done. Show quoted text On 2016/10/06 17:28:44, sky wrote: > DISALLOW... Done.
	24

	25 #endif // CHROME_BROWSER_RAPPOR_RECORDER_IMPL_H_

OLD	NEW