Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Unified Diff: components/rappor/recorder/BUILD.gn

Issue 2376403003: Convert RapporRecorder to use mojo. (Closed)
Patch Set: Convert RapporRecorder to use mojo. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/rappor/recorder/BUILD.gn
diff --git a/services/shell/runner/common/BUILD.gn b/components/rappor/recorder/BUILD.gn
similarity index 57%
copy from services/shell/runner/common/BUILD.gn
copy to components/rappor/recorder/BUILD.gn
index 4bb5387fbdc8eabafa1d9b9c737432f001300e09..dfa93143450cc211a9de5ab6892d9308806e9513 100644
--- a/services/shell/runner/common/BUILD.gn
+++ b/components/rappor/recorder/BUILD.gn
@@ -2,22 +2,19 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-source_set("common") {
+static_library("recorder") {
sky 2016/10/07 16:17:38 IMO I would move this code into components/rappor
Alexei Svitkine (slow) 2016/10/07 16:31:58 Agree, I don't think it's worth having a separate
nigeltao1 2016/10/11 23:44:55 Done.
sources = [
- "client_util.cc",
- "client_util.h",
- "switches.cc",
- "switches.h",
+ "rappor_recorder_impl.cc",
+ "rappor_recorder_impl.h",
]
- deps = [
+ public_deps = [
"//base",
- "//mojo/edk/system",
- "//mojo/public/cpp/bindings",
- "//mojo/public/cpp/system",
+ "//components/rappor/public/interfaces",
]
- public_deps = [
- "//services/shell/public/interfaces",
+ deps = [
+ "//components/rappor",
+ "//mojo/public/cpp/bindings",
]
}

Powered by Google App Engine
This is Rietveld 408576698