components/rappor/recorder/BUILD.gn - Issue 2376403003: Convert RapporRecorder to use mojo.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/rappor/recorder/BUILD.gn

Issue 2376403003: Convert RapporRecorder to use mojo. (Closed)

Patch Set: Convert RapporRecorder to use mojo. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/renderer/chrome_content_renderer_client.h ('K') | « components/rappor/public/interfaces/rappor_recorder.mojom ('k') | components/rappor/recorder/rappor_recorder_impl.h » ('j') | components/rappor/recorder/rappor_recorder_impl.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # Copyright 2016 The Chromium Authors. All rights reserved.	1 # Copyright 2016 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 source_set("common") {	5 static_library("recorder") {
	sky 2016/10/07 16:17:38 IMO I would move this code into components/rappor IMO I would move this code into components/rappor and put these files there. That said, I'm not an owner of this directory. So, you'll need to work with local owners. Alexei Svitkine (slow) 2016/10/07 16:31:58 Agree, I don't think it's worth having a separate Show quoted text On 2016/10/07 16:17:38, sky wrote: > IMO I would move this code into components/rappor and put these files there. > That said, I'm not an owner of this directory. So, you'll need to work with > local owners. Agree, I don't think it's worth having a separate sub-directory for this. nigeltao1 2016/10/11 23:44:55 Done. Show quoted text On 2016/10/07 16:31:58, Alexei Svitkine (slow) wrote: > On 2016/10/07 16:17:38, sky wrote: > > IMO I would move this code into components/rappor and put these files there. > > That said, I'm not an owner of this directory. So, you'll need to work with > > local owners. > > Agree, I don't think it's worth having a separate sub-directory for this. Done.
6 sources = [	6 sources = [

7 "client_util.cc",	7 "rappor_recorder_impl.cc",

8 "client_util.h",	8 "rappor_recorder_impl.h",

9 "switches.cc",	9 ]

10 "switches.h",	10

	11 public_deps = [

	12 "//base",

	13 "//components/rappor/public/interfaces",

11 ]	14 ]

12	15

13 deps = [	16 deps = [

14 "//base",	17 "//components/rappor",

15 "//mojo/edk/system",

16 "//mojo/public/cpp/bindings",	18 "//mojo/public/cpp/bindings",

17 "//mojo/public/cpp/system",

18 ]

19

20 public_deps = [

21 "//services/shell/public/interfaces",

22 ]	19 ]

23 }	20 }

OLD	NEW