Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 2376353002: Apply media controls button Android rules for all of them. (Closed)

Created:
4 years, 2 months ago by mlamouri (slow - plz ping)
Modified:
4 years, 2 months ago
Reviewers:
foolip
CC:
chromium-reviews, nessy, mlamouri+watch-blink_chromium.org, blink-reviews-css, blink-reviews-paint_chromium.org, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, dshwang, apavlov+blink_chromium.org, slimming-paint-reviews_chromium.org, darktears, blink-reviews, Srirama, vcarbune.chromium, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Apply media controls button Android rules for all of them. Two buttons were missing. Putting them all under the same rule. This is also fixing overflow and download button painter to take inte account paddings. BUG=650670 R=foolip@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/a7843803a37cba0707d44d19f5e70b02c05f554c Cr-Commit-Position: refs/heads/master@{#421956}

Patch Set 1 #

Patch Set 2 : rebaseline #

Messages

Total messages: 13 (8 generated)
mlamouri (slow - plz ping)
foolip@ PTAL :)
4 years, 2 months ago (2016-09-29 12:46:43 UTC) #4
foolip
lgtm, but I'm guessing some tests will need updating
4 years, 2 months ago (2016-09-29 12:50:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2376353002/20001
4 years, 2 months ago (2016-09-29 20:23:37 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-29 22:25:30 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 22:28:36 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a7843803a37cba0707d44d19f5e70b02c05f554c
Cr-Commit-Position: refs/heads/master@{#421956}

Powered by Google App Engine
This is Rietveld 408576698