Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 237633002: Added skeleon directory for hwcplus (Closed)

Created:
6 years, 8 months ago by rjkroege
Modified:
6 years, 8 months ago
CC:
chromium-reviews, fjhenigman
Visibility:
Public.

Description

Added skeleon directory for hwcplus hwcplus is needed for ozone-freon. Per https://goto.google.com/freon-ozone BUG=361139 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264079

Patch Set 1 #

Total comments: 1

Patch Set 2 : Updated license. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, --1 lines) Patch
A + third_party/hwcplus/LICENSE View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/hwcplus/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/hwcplus/README.chromium View 1 1 chunk +13 lines, -0 lines 2 comments Download

Messages

Total messages: 11 (0 generated)
rjkroege
Please take a look.
6 years, 8 months ago (2014-04-14 20:27:09 UTC) #1
fjhenigman
https://codereview.chromium.org/237633002/diff/1/third_party/hwcplus/README.chromium File third_party/hwcplus/README.chromium (right): https://codereview.chromium.org/237633002/diff/1/third_party/hwcplus/README.chromium#newcode5 third_party/hwcplus/README.chromium:5: License: BSD I'm planning to copy android-x86 files to ...
6 years, 8 months ago (2014-04-14 20:45:52 UTC) #2
rjkroege
On 2014/04/14 20:45:52, fjhenigman wrote: > https://codereview.chromium.org/237633002/diff/1/third_party/hwcplus/README.chromium > File third_party/hwcplus/README.chromium (right): > > https://codereview.chromium.org/237633002/diff/1/third_party/hwcplus/README.chromium#newcode5 > ...
6 years, 8 months ago (2014-04-14 20:48:44 UTC) #3
tfarina
https://codereview.chromium.org/237633002/diff/20001/third_party/hwcplus/README.chromium File third_party/hwcplus/README.chromium (right): https://codereview.chromium.org/237633002/diff/20001/third_party/hwcplus/README.chromium#newcode3 third_party/hwcplus/README.chromium:3: URL: http://src.chromium.org/viewvc/chrome/trunk/src/third_party/hwcplus/ Can you use an url from chromium.googlesource.com ...
6 years, 8 months ago (2014-04-15 02:34:17 UTC) #4
rjkroege
https://codereview.chromium.org/237633002/diff/20001/third_party/hwcplus/README.chromium File third_party/hwcplus/README.chromium (right): https://codereview.chromium.org/237633002/diff/20001/third_party/hwcplus/README.chromium#newcode3 third_party/hwcplus/README.chromium:3: URL: http://src.chromium.org/viewvc/chrome/trunk/src/third_party/hwcplus/ On 2014/04/15 02:34:18, tfarina wrote: > Can ...
6 years, 8 months ago (2014-04-15 17:51:01 UTC) #5
tfarina
On 2014/04/15 17:51:01, rjkroege wrote: > https://codereview.chromium.org/237633002/diff/20001/third_party/hwcplus/README.chromium > File third_party/hwcplus/README.chromium (right): > > https://codereview.chromium.org/237633002/diff/20001/third_party/hwcplus/README.chromium#newcode3 > ...
6 years, 8 months ago (2014-04-15 18:15:20 UTC) #6
Ben Goodger (Google)
lgtm for the addition
6 years, 8 months ago (2014-04-15 20:58:09 UTC) #7
rjkroege
The CQ bit was checked by rjkroege@chromium.org
6 years, 8 months ago (2014-04-15 21:05:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rjkroege@chromium.org/237633002/20001
6 years, 8 months ago (2014-04-15 21:07:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rjkroege@chromium.org/237633002/20001
6 years, 8 months ago (2014-04-16 01:27:22 UTC) #10
commit-bot: I haz the power
6 years, 8 months ago (2014-04-16 02:45:39 UTC) #11
Message was sent while issue was closed.
Change committed as 264079

Powered by Google App Engine
This is Rietveld 408576698