Chromium Code Reviews| Index: git_cl.py |
| diff --git a/git_cl.py b/git_cl.py |
| index 133713b073bb55d5899a27d7a33d8727a2336a13..c2675730cc4fc9c92de43750eca680381a6384bd 100755 |
| --- a/git_cl.py |
| +++ b/git_cl.py |
| @@ -2618,13 +2618,6 @@ class _GerritChangelistImpl(_ChangelistCodereviewBase): |
| else: |
| refspec_opts.append('notify=NONE') |
| - cc = self.GetCCList().split(',') |
| - if options.cc: |
| - cc.extend(options.cc) |
| - cc = filter(None, cc) |
| - if cc: |
| - refspec_opts.extend('cc=' + email.strip() for email in cc) |
| - |
| reviewers = change_desc.get_reviewers() |
| if reviewers: |
| refspec_opts.extend('r=' + email.strip() for email in reviewers) |
| @@ -2662,6 +2655,16 @@ class _GerritChangelistImpl(_ChangelistCodereviewBase): |
| 'Change-Id: %s') % (len(change_numbers), change_id)) |
| self.SetIssue(change_numbers[0]) |
| self._GitSetBranchConfigValue('gerritsquashhash', ref_to_push) |
| + |
| + # Add cc's from the CC_LIST and --cc flag (if any). |
| + cc = self.GetCCList().split(',') |
| + if options.cc: |
| + cc.extend(options.cc) |
| + cc = filter(None, [email.strip() for email in cc]) |
|
tandrii(chromium)
2016/09/29 11:27:24
email.strip() is the fix.
|
| + if cc: |
| + gerrit_util.AddReviewers( |
| + self._GetGerritHost(), self.GetIssue(), cc, is_reviewer=False) |
| + |
| return 0 |
| def _AddChangeIdToCommitMessage(self, options, args): |