Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2376293005:
cros: Tweaked the good/bad pin checking on the js to use the new quick unlock api function. (Closed)
|
Created:
4 years, 2 months ago by sammiequon Modified:
3 years, 11 months ago CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptioncros: Tweaked the good/bad pin checking on the js to use the new quick unlock api function.
BUG=612271
TEST=browser_tests --gtest_filter="CrSettingsPeoplePageSetupPinDialogTest*"
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/7ce2c3e2cc6caf9d0015ad102866f05adf29dd51
Cr-Commit-Position: refs/heads/master@{#441263}
Patch Set 1 #
Total comments: 6
Patch Set 2 : Fixed patch set 1 errors. #
Total comments: 2
Patch Set 3 : Rebased. #Patch Set 4 : Nit. #Patch Set 5 : Rebased. #Patch Set 6 : Rebased. #Patch Set 7 : Api update changes. #Patch Set 8 : Trybots. #Patch Set 9 : Added a comment. #
Total comments: 16
Patch Set 10 : Fixed patch set 9 errors. #
Total comments: 4
Patch Set 11 : Fixed patch set 10 errors. #Patch Set 12 : Rebased. #
Total comments: 4
Patch Set 13 : Fixed patch set 12 errors. #Messages
Total messages: 72 (55 generated)
Description was changed from ========== cros: Tweaked the good/bad pin checking on the js to use the new quick unlock api function. BUG=612271 TEST=none ========== to ========== cros: Tweaked the good/bad pin checking on the js to use the new quick unlock api function. BUG=612271 TEST=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Patchset #1 (id:1) has been deleted
Description was changed from ========== cros: Tweaked the good/bad pin checking on the js to use the new quick unlock api function. BUG=612271 TEST=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== cros: Tweaked the good/bad pin checking on the js to use the new quick unlock api function. BUG=612271 TEST=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
sammiequon@chromium.org changed reviewers: + jdufault@chromium.org
On 2016/09/30 01:25:54, sammiequon wrote: > mailto:sammiequon@chromium.org changed reviewers: > + mailto:jdufault@chromium.org jdufault@ - Please take a look. Thanks!
https://codereview.chromium.org/2376293005/diff/20001/chrome/app/settings_str... File chrome/app/settings_strings.grdp (right): https://codereview.chromium.org/2376293005/diff/20001/chrome/app/settings_str... chrome/app/settings_strings.grdp:1846: <message name="IDS_SETTINGS_PEOPLE_CONFIGURE_PIN_TOO_SHORT" desc="Message shown below the title that tells the user that the PIN they entered needs to be at least minimum digits long."> Talk to Tom about what the strings should be. https://codereview.chromium.org/2376293005/diff/20001/chrome/browser/resource... File chrome/browser/resources/settings/people_page/setup_pin_dialog.js (right): https://codereview.chromium.org/2376293005/diff/20001/chrome/browser/resource... chrome/browser/resources/settings/people_page/setup_pin_dialog.js:116: this.problemMessage_ = loadTimeData.getStringF(messageId, It looks like this.i18n handles parameters as well. Why did you switch to loadTimeData? https://codereview.chromium.org/2376293005/diff/20001/chrome/browser/resource... chrome/browser/resources/settings/people_page/setup_pin_dialog.js:136: processCredentials_: function(message) { What about naming this processPinProblems_?
https://codereview.chromium.org/2376293005/diff/20001/chrome/app/settings_str... File chrome/app/settings_strings.grdp (right): https://codereview.chromium.org/2376293005/diff/20001/chrome/app/settings_str... chrome/app/settings_strings.grdp:1846: <message name="IDS_SETTINGS_PEOPLE_CONFIGURE_PIN_TOO_SHORT" desc="Message shown below the title that tells the user that the PIN they entered needs to be at least minimum digits long."> On 2016/09/30 16:40:45, jdufault wrote: > Talk to Tom about what the strings should be. He seems to be OOO these days. I will talk to him asap. https://codereview.chromium.org/2376293005/diff/20001/chrome/browser/resource... File chrome/browser/resources/settings/people_page/setup_pin_dialog.js (right): https://codereview.chromium.org/2376293005/diff/20001/chrome/browser/resource... chrome/browser/resources/settings/people_page/setup_pin_dialog.js:116: this.problemMessage_ = loadTimeData.getStringF(messageId, On 2016/09/30 16:40:45, jdufault wrote: > It looks like this.i18n handles parameters as well. Why did you switch to > loadTimeData? Done. https://codereview.chromium.org/2376293005/diff/20001/chrome/browser/resource... chrome/browser/resources/settings/people_page/setup_pin_dialog.js:136: processCredentials_: function(message) { On 2016/09/30 16:40:45, jdufault wrote: > What about naming this processPinProblems_? Done.
lgtm https://codereview.chromium.org/2376293005/diff/40001/chrome/browser/resource... File chrome/browser/resources/settings/people_page/setup_pin_dialog.js (right): https://codereview.chromium.org/2376293005/diff/40001/chrome/browser/resource... chrome/browser/resources/settings/people_page/setup_pin_dialog.js:136: if (message.failures.length < 1) { if (!messages.failures) { this.hideProblem_(); return; }
https://codereview.chromium.org/2376293005/diff/40001/chrome/browser/resource... File chrome/browser/resources/settings/people_page/setup_pin_dialog.js (right): https://codereview.chromium.org/2376293005/diff/40001/chrome/browser/resource... chrome/browser/resources/settings/people_page/setup_pin_dialog.js:136: if (message.failures.length < 1) { On 2016/10/04 23:11:45, jdufault wrote: > if (!messages.failures) { > this.hideProblem_(); > return; > } Done.
On 2016/10/24 21:16:10, sammiequon wrote: > https://codereview.chromium.org/2376293005/diff/40001/chrome/browser/resource... > File chrome/browser/resources/settings/people_page/setup_pin_dialog.js (right): > > https://codereview.chromium.org/2376293005/diff/40001/chrome/browser/resource... > chrome/browser/resources/settings/people_page/setup_pin_dialog.js:136: if > (message.failures.length < 1) { > On 2016/10/04 23:11:45, jdufault wrote: > > if (!messages.failures) { > > this.hideProblem_(); > > return; > > } > > Done. I suspect that this needs to be rebased.
The CQ bit was checked by sammiequon@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_x86-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) closure_compilation on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by sammiequon@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: closure_compilation on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)
The CQ bit was checked by sammiequon@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
sammiequon@chromium.org changed reviewers: + stevenjb@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by sammiequon@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by sammiequon@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: closure_compilation on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)
Patchset #8 (id:160001) has been deleted
The CQ bit was checked by sammiequon@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
stevenjb@ - Please take a look. Thanks!
https://codereview.chromium.org/2376293005/diff/200001/chrome/browser/resourc... File chrome/browser/resources/settings/people_page/setup_pin_dialog.js (right): https://codereview.chromium.org/2376293005/diff/200001/chrome/browser/resourc... chrome/browser/resources/settings/people_page/setup_pin_dialog.js:89: }, Rather than make two overridable methods here (and potentially more in the future?) we should make a quickUnlockApi_ member here that implements the interface in quick_unlock_private_interface.js, then either use the fake implementation defined in fake_quick_unlock_private.js, or a test specific fake implementation. See password_prompt_dialog.js for an example. https://codereview.chromium.org/2376293005/diff/200001/chrome/browser/resourc... chrome/browser/resources/settings/people_page/setup_pin_dialog.js:141: * @param {string} problemClass This should really be a locally defined enum. https://codereview.chromium.org/2376293005/diff/200001/chrome/browser/resourc... chrome/browser/resources/settings/people_page/setup_pin_dialog.js:163: } This is probably worth breaking out into a separate, typed method. Also, the function comment is a little unclear; this doesn't really 'print' anything, it sets |this.problemMessage_|. https://codereview.chromium.org/2376293005/diff/200001/chrome/browser/resourc... chrome/browser/resources/settings/people_page/setup_pin_dialog.js:172: this.enableSubmit_ = false; this.enableSubmit_ = problemClass != 'error' && messageId != 'configurePinMismatched'; https://codereview.chromium.org/2376293005/diff/200001/chrome/browser/resourc... chrome/browser/resources/settings/people_page/setup_pin_dialog.js:186: * received from checkCredential. 4 space indent from @param https://codereview.chromium.org/2376293005/diff/200001/chrome/browser/resourc... chrome/browser/resources/settings/people_page/setup_pin_dialog.js:197: case 'TOO_WEAK': This should be defined in quick_unlock_private.idl and the constant used here. Same for errors below. https://codereview.chromium.org/2376293005/diff/200001/chrome/browser/resourc... chrome/browser/resources/settings/people_page/setup_pin_dialog.js:233: } early exit and elim else https://codereview.chromium.org/2376293005/diff/200001/third_party/closure_co... File third_party/closure_compiler/externs/quick_unlock_private.js (right): https://codereview.chromium.org/2376293005/diff/200001/third_party/closure_co... third_party/closure_compiler/externs/quick_unlock_private.js:36: }; I assume that the .idl was changed previously but we neglected to update the externs? We should update the interface also: python ./tools/json_schema_compiler/compiler.py -g interface chrome/common/extensions/api/quick_unlock_private.idl > third_party/closure_compiler/interfaces/quick_unlock_private_interface.js
Patchset #10 (id:220001) has been deleted
https://codereview.chromium.org/2376293005/diff/200001/chrome/browser/resourc... File chrome/browser/resources/settings/people_page/setup_pin_dialog.js (right): https://codereview.chromium.org/2376293005/diff/200001/chrome/browser/resourc... chrome/browser/resources/settings/people_page/setup_pin_dialog.js:89: }, On 2016/12/14 23:46:34, stevenjb wrote: > Rather than make two overridable methods here (and potentially more in the > future?) we should make a quickUnlockApi_ member here that implements the > interface in quick_unlock_private_interface.js, then either use the fake > implementation defined in fake_quick_unlock_private.js, or a test specific fake > implementation. > > See password_prompt_dialog.js for an example. Done. https://codereview.chromium.org/2376293005/diff/200001/chrome/browser/resourc... chrome/browser/resources/settings/people_page/setup_pin_dialog.js:141: * @param {string} problemClass On 2016/12/14 23:46:34, stevenjb wrote: > This should really be a locally defined enum. Done. https://codereview.chromium.org/2376293005/diff/200001/chrome/browser/resourc... chrome/browser/resources/settings/people_page/setup_pin_dialog.js:163: } On 2016/12/14 23:46:34, stevenjb wrote: > This is probably worth breaking out into a separate, typed method. Also, the > function comment is a little unclear; this doesn't really 'print' anything, it > sets |this.problemMessage_|. Done. https://codereview.chromium.org/2376293005/diff/200001/chrome/browser/resourc... chrome/browser/resources/settings/people_page/setup_pin_dialog.js:172: this.enableSubmit_ = false; On 2016/12/14 23:46:34, stevenjb wrote: > this.enableSubmit_ = > problemClass != 'error' && messageId != 'configurePinMismatched'; Done. https://codereview.chromium.org/2376293005/diff/200001/chrome/browser/resourc... chrome/browser/resources/settings/people_page/setup_pin_dialog.js:186: * received from checkCredential. On 2016/12/14 23:46:34, stevenjb wrote: > 4 space indent from @param Done. https://codereview.chromium.org/2376293005/diff/200001/chrome/browser/resourc... chrome/browser/resources/settings/people_page/setup_pin_dialog.js:197: case 'TOO_WEAK': On 2016/12/14 23:46:34, stevenjb wrote: > This should be defined in quick_unlock_private.idl and the constant used here. > Same for errors below. > Done. https://codereview.chromium.org/2376293005/diff/200001/chrome/browser/resourc... chrome/browser/resources/settings/people_page/setup_pin_dialog.js:233: } On 2016/12/14 23:46:34, stevenjb wrote: > early exit and elim else Done. https://codereview.chromium.org/2376293005/diff/200001/third_party/closure_co... File third_party/closure_compiler/externs/quick_unlock_private.js (right): https://codereview.chromium.org/2376293005/diff/200001/third_party/closure_co... third_party/closure_compiler/externs/quick_unlock_private.js:36: }; On 2016/12/14 23:46:34, stevenjb wrote: > I assume that the .idl was changed previously but we neglected to update the > externs? We should update the interface also: > > python ./tools/json_schema_compiler/compiler.py -g interface > chrome/common/extensions/api/quick_unlock_private.idl > > third_party/closure_compiler/interfaces/quick_unlock_private_interface.js Yeah, forgot to update in a previous CL. Done.
https://codereview.chromium.org/2376293005/diff/240001/chrome/browser/resourc... File chrome/browser/resources/settings/people_page/setup_pin_dialog.js (right): https://codereview.chromium.org/2376293005/diff/240001/chrome/browser/resourc... chrome/browser/resources/settings/people_page/setup_pin_dialog.js:204: } Simplify: assert (message.warnings[0] == chrome.quickUnlockPrivate.CredentialProblem.TOO_WEAK); this.showProblem_(MessageType.TOO_WEAK, ProblemType.WARNING); https://codereview.chromium.org/2376293005/diff/240001/chrome/test/data/webui... File chrome/test/data/webui/settings/quick_unlock_authenticate_browsertest_chromeos.js (right): https://codereview.chromium.org/2376293005/diff/240001/chrome/test/data/webui... chrome/test/data/webui/settings/quick_unlock_authenticate_browsertest_chromeos.js:398: }); Shouldn't we add a too long test?
The CQ bit was checked by sammiequon@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
The CQ bit was checked by sammiequon@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
Patchset #12 (id:280001) has been deleted
Patchset #12 (id:300001) has been deleted
The CQ bit was checked by sammiequon@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2376293005/diff/240001/chrome/browser/resourc... File chrome/browser/resources/settings/people_page/setup_pin_dialog.js (right): https://codereview.chromium.org/2376293005/diff/240001/chrome/browser/resourc... chrome/browser/resources/settings/people_page/setup_pin_dialog.js:204: } On 2016/12/19 19:01:29, stevenjb wrote: > Simplify: > > assert (message.warnings[0] == > chrome.quickUnlockPrivate.CredentialProblem.TOO_WEAK); > this.showProblem_(MessageType.TOO_WEAK, ProblemType.WARNING); Done. https://codereview.chromium.org/2376293005/diff/240001/chrome/test/data/webui... File chrome/test/data/webui/settings/quick_unlock_authenticate_browsertest_chromeos.js (right): https://codereview.chromium.org/2376293005/diff/240001/chrome/test/data/webui... chrome/test/data/webui/settings/quick_unlock_authenticate_browsertest_chromeos.js:398: }); On 2016/12/19 19:01:29, stevenjb wrote: > Shouldn't we add a too long test? Done.
https://codereview.chromium.org/2376293005/diff/320001/chrome/browser/resourc... File chrome/browser/resources/settings/people_page/setup_pin_dialog.js (right): https://codereview.chromium.org/2376293005/diff/320001/chrome/browser/resourc... chrome/browser/resources/settings/people_page/setup_pin_dialog.js:220: this.showProblem_(MessageType.TOO_LONG, ProblemType.ERROR); break; https://codereview.chromium.org/2376293005/diff/320001/chrome/test/data/webui... File chrome/test/data/webui/settings/quick_unlock_authenticate_browsertest_chromeos.js (right): https://codereview.chromium.org/2376293005/diff/320001/chrome/test/data/webui... chrome/test/data/webui/settings/quick_unlock_authenticate_browsertest_chromeos.js:419: assertTrue(continueButton.disabled); We should also test that a shorter pin is valid when maxLength is set.
Description was changed from ========== cros: Tweaked the good/bad pin checking on the js to use the new quick unlock api function. BUG=612271 TEST=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== cros: Tweaked the good/bad pin checking on the js to use the new quick unlock api function. BUG=612271 TEST=browser_tests --gtest_filter="CrSettingsPeoplePageSetupPinDialogTest*" CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by sammiequon@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2376293005/diff/320001/chrome/browser/resourc... File chrome/browser/resources/settings/people_page/setup_pin_dialog.js (right): https://codereview.chromium.org/2376293005/diff/320001/chrome/browser/resourc... chrome/browser/resources/settings/people_page/setup_pin_dialog.js:220: this.showProblem_(MessageType.TOO_LONG, ProblemType.ERROR); On 2017/01/03 18:35:13, stevenjb wrote: > break; Done. https://codereview.chromium.org/2376293005/diff/320001/chrome/test/data/webui... File chrome/test/data/webui/settings/quick_unlock_authenticate_browsertest_chromeos.js (right): https://codereview.chromium.org/2376293005/diff/320001/chrome/test/data/webui... chrome/test/data/webui/settings/quick_unlock_authenticate_browsertest_chromeos.js:419: assertTrue(continueButton.disabled); On 2017/01/03 18:35:13, stevenjb wrote: > We should also test that a shorter pin is valid when maxLength is set. Done.
lgtm
The CQ bit was checked by sammiequon@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jdufault@chromium.org Link to the patchset: https://codereview.chromium.org/2376293005/#ps340001 (title: "Fixed patch set 12 errors.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 340001, "attempt_start_ts": 1483489084724770,
"parent_rev": "fba959c19d32bee132bd84c2308d659690ec9b5a", "commit_rev":
"bfea5ab532926434a36b52e812ec36d47af26c21"}
Message was sent while issue was closed.
Description was changed from ========== cros: Tweaked the good/bad pin checking on the js to use the new quick unlock api function. BUG=612271 TEST=browser_tests --gtest_filter="CrSettingsPeoplePageSetupPinDialogTest*" CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== cros: Tweaked the good/bad pin checking on the js to use the new quick unlock api function. BUG=612271 TEST=browser_tests --gtest_filter="CrSettingsPeoplePageSetupPinDialogTest*" CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2376293005 ==========
Message was sent while issue was closed.
Committed patchset #13 (id:340001)
Message was sent while issue was closed.
Description was changed from ========== cros: Tweaked the good/bad pin checking on the js to use the new quick unlock api function. BUG=612271 TEST=browser_tests --gtest_filter="CrSettingsPeoplePageSetupPinDialogTest*" CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2376293005 ========== to ========== cros: Tweaked the good/bad pin checking on the js to use the new quick unlock api function. BUG=612271 TEST=browser_tests --gtest_filter="CrSettingsPeoplePageSetupPinDialogTest*" CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/7ce2c3e2cc6caf9d0015ad102866f05adf29dd51 Cr-Commit-Position: refs/heads/master@{#441263} ==========
Message was sent while issue was closed.
Patchset 13 (id:??) landed as https://crrev.com/7ce2c3e2cc6caf9d0015ad102866f05adf29dd51 Cr-Commit-Position: refs/heads/master@{#441263} |
