Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 2376293004: Don't show media controls download button on local files. (Closed)

Created:
4 years, 2 months ago by mlamouri (slow - plz ping)
Modified:
4 years, 2 months ago
Reviewers:
gone
CC:
chromium-reviews, nessy, feature-media-reviews_chromium.org, posciak+watch_chromium.org, blink-reviews-html_chromium.org, gasubic, fs, eric.carlson_apple.com, mlamouri+watch-blink_chromium.org, dglazkov+blink, blink-reviews, Srirama, vcarbune.chromium
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't show media controls download button on local files. It requires moving a lot of tests so the files are not local. BUG=650449 R=dfalcantara@chromium.org Committed: https://crrev.com/aa4e87ce809127f1d8b1cd594d5e7ce838e4d38a Cr-Commit-Position: refs/heads/master@{#422103}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebaseline again \o/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -492 lines) Patch
A + third_party/WebKit/LayoutTests/http/tests/media/video-controls-download-button-displayed.html View 2 chunks +3 lines, -3 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/media/video-controls-download-button-not-displayed-mediastream.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/media/video-controls-download-button-not-displayed-mse.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/media/video-controls-download-button-saves-media.html View 2 chunks +4 lines, -4 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/media/video-controls-download-button-saves-media-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/media/video-controls-overflow-menu-correct-ordering.html View 2 chunks +4 lines, -4 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/media/video-controls-overflow-menu-download-button.html View 2 chunks +4 lines, -4 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/media/video-controls-overflow-menu-download-button-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/media/video-controls-overflow-menu-updates-appropriately.html View 2 chunks +4 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/video-controls-download-button-displayed.html View 1 chunk +0 lines, -22 lines 0 comments Download
A + third_party/WebKit/LayoutTests/media/video-controls-download-button-not-displayed-local.html View 1 chunk +3 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/video-controls-download-button-not-displayed-mediastream.html View 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/video-controls-download-button-not-displayed-mse.html View 1 chunk +0 lines, -19 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/video-controls-download-button-saves-media.html View 1 chunk +0 lines, -31 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/video-controls-download-button-saves-media-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-correct-ordering.html View 1 chunk +0 lines, -45 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-download-button.html View 1 chunk +0 lines, -38 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-download-button-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-updates-appropriately.html View 1 chunk +0 lines, -54 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/video-mute-repaint-expected.txt View 1 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/video-unmute-repaint-expected.txt View 1 1 chunk +6 lines, -6 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/paint/invalidation/video-mute-repaint-expected.txt View 1 1 chunk +0 lines, -96 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/paint/invalidation/video-unmute-repaint-expected.txt View 1 1 chunk +0 lines, -96 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/compositing/video/video-controls-layer-creation-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/media/video-zoom-controls-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/media/video-zoom-controls-expected.txt View 1 4 chunks +14 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/android/fullscreen/full-screen-iframe-allowed-video-expected.png View 1 2 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/android/fullscreen/video-controls-timeline-expected.png View 1 2 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/android/fullscreen/video-scrolled-iframe-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/compositing/video/video-controls-layer-creation-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/media/controls-timeline-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/media/video-zoom-controls-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/media/video-zoom-controls-expected.txt View 1 4 chunks +14 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/media/video-zoom-controls-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/media/video-zoom-controls-expected.txt View 1 4 chunks +14 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp View 1 chunk +17 lines, -4 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
mlamouri (slow - plz ping)
dfalcantara@ PTAL :)
4 years, 2 months ago (2016-09-29 20:14:50 UTC) #3
gone
lgtm
4 years, 2 months ago (2016-09-29 20:25:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2376293004/1
4 years, 2 months ago (2016-09-29 20:26:38 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/306703)
4 years, 2 months ago (2016-09-29 21:20:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2376293004/20001
4 years, 2 months ago (2016-09-30 11:13:27 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2376293004/40001
4 years, 2 months ago (2016-09-30 12:46:58 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-09-30 13:59:37 UTC) #16
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 14:01:30 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/aa4e87ce809127f1d8b1cd594d5e7ce838e4d38a
Cr-Commit-Position: refs/heads/master@{#422103}

Powered by Google App Engine
This is Rietveld 408576698