third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-updates-appropriately.html - Issue 2376293004: Don't show media controls download button on local files.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-updates-appropriately.html

Issue 2376293004: Don't show media controls download button on local files. (Closed)

Patch Set: rebaseline again \o/ Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-download-button-expected.txt ('k') | third_party/WebKit/LayoutTests/paint/invalidation/video-mute-repaint-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
	(Empty)
1 <!DOCTYPE html>

2 <title>Overflow menu updates properly.</title>

3 <script src="../resources/testharness.js"></script>

4 <script src="../resources/testharnessreport.js"></script>

5 <script src="media-controls.js"></script>

6 <script src="media-file.js"></script>

7 <script src="overflow-menu.js"></script>

8

9 <!--Padding ensures the overflow menu is visible for the tests. -->

10 <body style="padding-top: 200px; padding-left: 100px">

11 <video controls></video>

12 <script>

13 async_test(function(t) {

14 // Set up video

15 var video = document.querySelector("video");

16 video.src = findMediaFile("video", "content/test");

17 video.setAttribute("width", "60");

18 // Add captions

19 var trackElement = document.createElement("track");

20 video.appendChild(trackElement);

21 // Pretend we have a cast device

22 internals.mediaPlayerRemoteRouteAvailabilityChanged(video, true);

23

24 video.onloadeddata = t.step_func_done(function() {

25 var overflowList = getOverflowList(video);

26

27 // Remove cast device and ensure the overflow menu updates as expected

28 // Cast option in overflow should no longer be visible, but the other

29 // options should all be.

30 var buttonsWithoutCast = overflowButtonsCSS;

31 buttonsWithoutCast[OverflowMenuButtons.CAST] = undefined;

32 internals.mediaPlayerRemoteRouteAvailabilityChanged(video, false);

33

34 var children = overflowList.children;

35 // Ensure that all of the buttons are visible in the right order

36 for (var i = 0; i < children.length; i++) {

37 var child = children[i];

38 if (buttonsWithoutCast[i]) {

39 assert_not_equals(getComputedStyle(child).display, "none");

40 } else {

41 assert_equals(getComputedStyle(child).display, "none");

42 }

43 }

44 internals.mediaPlayerRemoteRouteAvailabilityChanged(video, true);

45 assert_not_equals(getComputedStyle(children[OverflowMenuButtons.CAST]).displ ay, "none");

46

47 // Removing closed captions hides button in overflow menu

48 assert_not_equals(getComputedStyle(children[OverflowMenuButtons.CLOSED_CAPTI ONS]).display, "none");

49 video.removeChild(trackElement);

50 assert_equals(getComputedStyle(children[OverflowMenuButtons.CLOSED_CAPTIONS] ).display, "none");

51 });

52 });

53 </script>

54 </body>

OLD	NEW