Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2376293003: gpu: support RG_88 GpuMemoryBuffer (Closed)

Created:
4 years, 2 months ago by dshwang
Modified:
4 years, 2 months ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), darin-cc_chromium.org, jam, kalyank, ozone-reviews_chromium.org, piman+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu: support RG_88 GpuMemoryBuffer 9-16 bit video channel will use it. BUG=445071, 624436 TEST=gl_tests --gtest_filter=GpuMemoryBufferTest* CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/961b0e1cfb0c951c9bcd824044e2fa95b611312e Cr-Commit-Position: refs/heads/master@{#422741}

Patch Set 1 #

Patch Set 2 : build fix ARM ChromeOS #

Patch Set 3 : resolve hubbe's review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -16 lines) Patch
M components/exo/buffer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/gpu/browser_gpu_memory_buffer_manager.cc View 1 chunk +9 lines, -4 lines 0 comments Download
M content/browser/gpu/gpu_internals_ui.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/common/gpu_memory_buffer_support.cc View 4 chunks +5 lines, -0 lines 0 comments Download
M gpu/command_buffer/tests/gl_gpu_memory_buffer_unittest.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M gpu/ipc/client/gpu_memory_buffer_impl_shared_memory.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/buffer_format_util.cc View 5 chunks +20 lines, -9 lines 0 comments Download
M ui/gfx/buffer_types.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/mac/io_surface.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/gfx/mojo/buffer_types.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/mojo/buffer_types_traits.h View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M ui/gl/gl_image_io_surface.mm View 5 chunks +7 lines, -0 lines 0 comments Download
M ui/gl/gl_image_memory.cc View 8 chunks +10 lines, -1 line 0 comments Download
M ui/gl/test/gl_image_test_support.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/ozone/gl/gl_image_ozone_native_pixmap.cc View 1 2 6 chunks +9 lines, -0 lines 0 comments Download
M ui/ozone/platform/drm/client_native_pixmap_factory_gbm.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M ui/ozone/platform/drm/common/drm_util.cc View 3 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 32 (21 generated)
dshwang
reveman@: Please review changes in ui/ spang@: Please review changes in ui/ozone piman@: Please review ...
4 years, 2 months ago (2016-09-29 15:36:59 UTC) #5
hubbe
non-owner LGTM
4 years, 2 months ago (2016-09-29 17:22:57 UTC) #8
reveman
lgtm
4 years, 2 months ago (2016-09-29 21:57:53 UTC) #13
hubbe
On 2016/09/29 21:57:53, reveman wrote: > lgtm I think you also need to add GL_RG_EXT ...
4 years, 2 months ago (2016-09-30 18:10:37 UTC) #14
dshwang
ccameron@: Please review changes in ui/ozone zmo@: Please review changes in content/ and gpu/ meacer@: ...
4 years, 2 months ago (2016-10-03 11:32:12 UTC) #20
Zhenyao Mo
On 2016/10/03 11:32:12, dshwang wrote: > ccameron@: Please review changes in ui/ozone > zmo@: Please ...
4 years, 2 months ago (2016-10-03 18:17:37 UTC) #23
meacer
On 2016/10/03 18:17:37, Zhenyao Mo wrote: > On 2016/10/03 11:32:12, dshwang wrote: > > ccameron@: ...
4 years, 2 months ago (2016-10-03 22:15:33 UTC) #24
ccameron
ui/ozone OWNER lgtm stamp
4 years, 2 months ago (2016-10-03 22:23:27 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2376293003/40001
4 years, 2 months ago (2016-10-04 10:11:18 UTC) #28
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-04 10:15:51 UTC) #30
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 10:17:48 UTC) #32
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/961b0e1cfb0c951c9bcd824044e2fa95b611312e
Cr-Commit-Position: refs/heads/master@{#422741}

Powered by Google App Engine
This is Rietveld 408576698