Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2376173002: [inspector] removed inspector_protocol_parser_test (Closed)

Created:
4 years, 2 months ago by kozy
Modified:
4 years, 2 months ago
Reviewers:
dgozman, Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] removed inspector_protocol_parser_test Unittests for protocol parser are located in core/inspector in blink and separate test runner for inspector tests was added. BUG=chromium:635948 R=dgozman@chromium.org,yangguo@chromium.org Committed: https://crrev.com/fa814c61191fb68234537222010a5e2630bc96ae Cr-Commit-Position: refs/heads/master@{#40226}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -57 lines) Patch
D test/inspector_protocol_parser_test/BUILD.gn View 1 chunk +0 lines, -6 lines 0 comments Download
D test/inspector_protocol_parser_test/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D test/inspector_protocol_parser_test/RunTests.cpp View 1 chunk +0 lines, -17 lines 0 comments Download
D test/inspector_protocol_parser_test/inspector_protocol_parser_test.gyp View 1 chunk +0 lines, -12 lines 0 comments Download
D test/inspector_protocol_parser_test/inspector_protocol_parser_test.isolate View 1 chunk +0 lines, -13 lines 0 comments Download
D test/inspector_protocol_parser_test/inspector_protocol_parser_test.status View 1 chunk +0 lines, -6 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (2 generated)
kozy
Dmitry and Yang, please take a look. I think we don't need this for now.
4 years, 2 months ago (2016-09-28 22:34:39 UTC) #1
kozy
ping!
4 years, 2 months ago (2016-10-11 20:14:44 UTC) #2
dgozman
lgtm
4 years, 2 months ago (2016-10-11 20:26:35 UTC) #3
Yang
On 2016/10/11 20:26:35, dgozman wrote: > lgtm lgtm.
4 years, 2 months ago (2016-10-12 09:09:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2376173002/1
4 years, 2 months ago (2016-10-12 13:47:48 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-12 14:13:41 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 14:14:08 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fa814c61191fb68234537222010a5e2630bc96ae
Cr-Commit-Position: refs/heads/master@{#40226}

Powered by Google App Engine
This is Rietveld 408576698