[Sync] Move //components/sync to the syncer namespace.

[Sync] Move //components/sync to the syncer namespace.

Things in components should live in namespaces that match their
component. Unfortunately "sync" is a symbol defined in the std library,
so in this case we are using "syncer".

This CL does the following things inside //components/sync:

- Replaces all uses of syncer_v2, sync_driver, sync_driver_v2, and browser_sync with syncer.
- Adds syncer namespace to some classes that were missing a namespace.
- Removes almost all "syncer::" prefixes since they became redundant.

Everything outside the component is just fixing namespace prefixes and forward declarations.
I also fixed *some* lints, especially in headers outside of the component.

This script was the starting point for this CL: http://pastebin.com/PPhPTtRK

BUG=646685
TBR=caitkp

Committed: https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a
Cr-Commit-Position: refs/heads/master@{#422239}

[maxbogue, 2016-09-29 20:49:23]

The CQ bit was checked by maxbogue@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 20:49:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 20:55:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 20:55:44]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[maxbogue, 2016-09-29 21:50:34]

The CQ bit was checked by maxbogue@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 21:51:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 22:09:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 22:09:49]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[maxbogue, 2016-09-30 17:32:13]

The CQ bit was checked by maxbogue@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 17:33:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[maxbogue, 2016-09-30 17:43:29]

maxbogue@chromium.org changed reviewers:
+ skym@chromium.org

[maxbogue, 2016-09-30 17:43:32]

Sky, PTAL! Sorry it's Very Large, but the most complicated changes in the CL are
reshuffling some forward declaration blocks so it shouldn't be too bad. Note
that I opted to not add closing namespace comments for forward declaration
blocks that were already missing them.

[maxbogue, 2016-09-30 18:06:04]

Description was changed from

==========
[Sync] Move //components/sync to the syncer namespace.

Things in components should live in namespaces that match their
component. Unfortunately "sync" is a symbol defined in the std library,
so in this case we are using "syncer".

BUG=646685
==========

to

==========
[Sync] Move //components/sync to the syncer namespace.

Things in components should live in namespaces that match their
component.
Unfortunately "sync" is a symbol defined in the std library,
so in this case
we are using "syncer".

This CL does the following things inside //components/sync:

- Replaces all uses of syncer_v2, sync_driver, sync_driver_v2, and browser_sync
with syncer.
- Adds syncer namespace to some classes that were missing a namespace.
- Removes almost all "syncer::" prefixes since they became redundant.

Everything outside the component is just fixing namespace prefixes and forward
declarations.
I also fixed *some* lints, especially in headers outside of the component.

BUG=646685
==========

[maxbogue, 2016-09-30 18:06:41]

Description was changed from

==========
[Sync] Move //components/sync to the syncer namespace.

Things in components should live in namespaces that match their
component.
Unfortunately "sync" is a symbol defined in the std library,
so in this case
we are using "syncer".

This CL does the following things inside //components/sync:

- Replaces all uses of syncer_v2, sync_driver, sync_driver_v2, and browser_sync
with syncer.
- Adds syncer namespace to some classes that were missing a namespace.
- Removes almost all "syncer::" prefixes since they became redundant.

Everything outside the component is just fixing namespace prefixes and forward
declarations.
I also fixed *some* lints, especially in headers outside of the component.

BUG=646685
==========

to

==========
[Sync] Move //components/sync to the syncer namespace.

Things in components should live in namespaces that match their
component. Unfortunately "sync" is a symbol defined in the std library,
so in this case we are using "syncer".

This CL does the following things inside //components/sync:

- Replaces all uses of syncer_v2, sync_driver, sync_driver_v2, and browser_sync
with syncer.
- Adds syncer namespace to some classes that were missing a namespace.
- Removes almost all "syncer::" prefixes since they became redundant.

Everything outside the component is just fixing namespace prefixes and forward
declarations.
I also fixed *some* lints, especially in headers outside of the component.

BUG=646685
==========

[commit-bot: I haz the power, 2016-09-30 18:37:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 18:37:19]

Dry run: This issue passed the CQ dry run.

[skym, 2016-09-30 19:03:23]

lgtm once the user { using syncer::syncable:: thing is fixed everywhere.

https://codereview.chromium.org/2376123003/diff/20001/components/browser_sync...
File components/browser_sync/profile_sync_service.h (right):

https://codereview.chromium.org/2376123003/diff/20001/components/browser_sync...
components/browser_sync/profile_sync_service.h:62: namespace syncer {
You mentioned offline that this was supposed to come after the sync_* ones.

https://codereview.chromium.org/2376123003/diff/20001/components/browser_sync...
components/browser_sync/profile_sync_service.h:71: class Proto;
What is syncer::Proto? I don't see it anywhere in here.

https://codereview.chromium.org/2376123003/diff/20001/components/sync/driver/...
File components/sync/driver/about_sync_util_unittest.cc (right):

https://codereview.chromium.org/2376123003/diff/20001/components/sync/driver/...
components/sync/driver/about_sync_util_unittest.cc:19: namespace sync_ui_util {
While you're in here, can you slap some newlines between these namespaces which
seems to be the convention?

https://codereview.chromium.org/2376123003/diff/20001/components/sync/driver/...
components/sync/driver/about_sync_util_unittest.cc:48: }  // namespace
same

https://codereview.chromium.org/2376123003/diff/20001/components/sync/driver/...
File components/sync/driver/user_selectable_sync_type.h (right):

https://codereview.chromium.org/2376123003/diff/20001/components/sync/driver/...
components/sync/driver/user_selectable_sync_type.h:9: namespace
user_selectable_type {
newline

https://codereview.chromium.org/2376123003/diff/20001/components/sync/driver/...
components/sync/driver/user_selectable_sync_type.h:22: // ModelType.
Might be good to leave the namespace here.

https://codereview.chromium.org/2376123003/diff/20001/components/sync/driver/...
components/sync/driver/user_selectable_sync_type.h:68: }  // namespace
user_selectable_type
newline

https://codereview.chromium.org/2376123003/diff/20001/components/sync/engine_...
File components/sync/engine_impl/syncer_proto_util.cc (right):

https://codereview.chromium.org/2376123003/diff/20001/components/sync/engine_...
components/sync/engine_impl/syncer_proto_util.cc:32: using
syncer::syncable::BASE_VERSION;
Is this really needed? Seems like you shouldn't have to, since you're already in
the syncer namespace.

https://codereview.chromium.org/2376123003/diff/20001/components/sync/syncabl...
File components/sync/syncable/dir_open_result.h (right):

https://codereview.chromium.org/2376123003/diff/20001/components/sync/syncabl...
components/sync/syncable/dir_open_result.h:8: namespace syncer {
newline

https://codereview.chromium.org/2376123003/diff/20001/components/sync/syncabl...
components/sync/syncable/dir_open_result.h:24: }  // namespace syncable
newline

https://codereview.chromium.org/2376123003/diff/20001/components/sync/syncabl...
File components/sync/syncable/directory_unittest.h (left):

https://codereview.chromium.org/2376123003/diff/20001/components/sync/syncabl...
components/sync/syncable/directory_unittest.h:25: 
*GASP*, okay maybe disregard all the earlier comments about needing newlines
between nested namespaces that are not type defing. I don't know. It'd be nice
if we were consistent...

[maxbogue, 2016-09-30 20:03:33]

The CQ bit was checked by maxbogue@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 20:04:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 20:10:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 20:10:56]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[maxbogue, 2016-09-30 20:13:41]

https://codereview.chromium.org/2376123003/diff/20001/components/browser_sync...
File components/browser_sync/profile_sync_service.h (right):

https://codereview.chromium.org/2376123003/diff/20001/components/browser_sync...
components/browser_sync/profile_sync_service.h:62: namespace syncer {
On 2016/09/30 19:03:22, skym wrote:
> You mentioned offline that this was supposed to come after the sync_* ones.

Done.

https://codereview.chromium.org/2376123003/diff/20001/components/browser_sync...
components/browser_sync/profile_sync_service.h:71: class Proto;
On 2016/09/30 19:03:22, skym wrote:
> What is syncer::Proto? I don't see it anywhere in here.

I have literally no idea where that came from. Good catch.

https://codereview.chromium.org/2376123003/diff/20001/components/sync/driver/...
File components/sync/driver/about_sync_util_unittest.cc (right):

https://codereview.chromium.org/2376123003/diff/20001/components/sync/driver/...
components/sync/driver/about_sync_util_unittest.cc:19: namespace sync_ui_util {
On 2016/09/30 19:03:22, skym wrote:
> While you're in here, can you slap some newlines between these namespaces
which
> seems to be the convention?

Acknowledged.

https://codereview.chromium.org/2376123003/diff/20001/components/sync/driver/...
components/sync/driver/about_sync_util_unittest.cc:48: }  // namespace
On 2016/09/30 19:03:22, skym wrote:
> same

Acknowledged.

https://codereview.chromium.org/2376123003/diff/20001/components/sync/driver/...
File components/sync/driver/user_selectable_sync_type.h (right):

https://codereview.chromium.org/2376123003/diff/20001/components/sync/driver/...
components/sync/driver/user_selectable_sync_type.h:9: namespace
user_selectable_type {
On 2016/09/30 19:03:22, skym wrote:
> newline

Acknowledged.

https://codereview.chromium.org/2376123003/diff/20001/components/sync/driver/...
components/sync/driver/user_selectable_sync_type.h:22: // ModelType.
On 2016/09/30 19:03:22, skym wrote:
> Might be good to leave the namespace here.

Done.

https://codereview.chromium.org/2376123003/diff/20001/components/sync/driver/...
components/sync/driver/user_selectable_sync_type.h:68: }  // namespace
user_selectable_type
On 2016/09/30 19:03:22, skym wrote:
> newline

Acknowledged.

https://codereview.chromium.org/2376123003/diff/20001/components/sync/engine_...
File components/sync/engine_impl/syncer_proto_util.cc (right):

https://codereview.chromium.org/2376123003/diff/20001/components/sync/engine_...
components/sync/engine_impl/syncer_proto_util.cc:32: using
syncer::syncable::BASE_VERSION;
On 2016/09/30 19:03:22, skym wrote:
> Is this really needed? Seems like you shouldn't have to, since you're already
in
> the syncer namespace.

Done, here and in another 20ish files where I messed it up.

https://codereview.chromium.org/2376123003/diff/20001/components/sync/syncabl...
File components/sync/syncable/dir_open_result.h (right):

https://codereview.chromium.org/2376123003/diff/20001/components/sync/syncabl...
components/sync/syncable/dir_open_result.h:8: namespace syncer {
On 2016/09/30 19:03:22, skym wrote:
> newline

Acknowledged.

https://codereview.chromium.org/2376123003/diff/20001/components/sync/syncabl...
components/sync/syncable/dir_open_result.h:24: }  // namespace syncable
On 2016/09/30 19:03:22, skym wrote:
> newline

Acknowledged.

https://codereview.chromium.org/2376123003/diff/20001/components/sync/syncabl...
File components/sync/syncable/directory_unittest.h (left):

https://codereview.chromium.org/2376123003/diff/20001/components/sync/syncabl...
components/sync/syncable/directory_unittest.h:25: 
On 2016/09/30 19:03:22, skym wrote:
> *GASP*, okay maybe disregard all the earlier comments about needing newlines
> between nested namespaces that are not type defing. I don't know. It'd be nice
> if we were consistent...

I think when they're just nested with nothing in between it makes sense to have
them tightly together.

[maxbogue, 2016-09-30 20:36:23]

maxbogue@chromium.org changed reviewers:
+ brettw@chromium.org

[maxbogue, 2016-09-30 20:36:25]

+brettw for OWNERS on everything non-sync. Brett, this change was largely
scripted, with some manual cleanup fixing forward declarations, missing
namespaces, and places find/replace broke stuff.

[maxbogue, 2016-09-30 20:37:18]

Description was changed from

==========
[Sync] Move //components/sync to the syncer namespace.

Things in components should live in namespaces that match their
component. Unfortunately "sync" is a symbol defined in the std library,
so in this case we are using "syncer".

This CL does the following things inside //components/sync:

- Replaces all uses of syncer_v2, sync_driver, sync_driver_v2, and browser_sync
with syncer.
- Adds syncer namespace to some classes that were missing a namespace.
- Removes almost all "syncer::" prefixes since they became redundant.

Everything outside the component is just fixing namespace prefixes and forward
declarations.
I also fixed *some* lints, especially in headers outside of the component.

BUG=646685
==========

to

==========
[Sync] Move //components/sync to the syncer namespace.

Things in components should live in namespaces that match their
component. Unfortunately "sync" is a symbol defined in the std library,
so in this case we are using "syncer".

This CL does the following things inside //components/sync:

- Replaces all uses of syncer_v2, sync_driver, sync_driver_v2, and browser_sync
with syncer.
- Adds syncer namespace to some classes that were missing a namespace.
- Removes almost all "syncer::" prefixes since they became redundant.

Everything outside the component is just fixing namespace prefixes and forward
declarations.
I also fixed *some* lints, especially in headers outside of the component.

This script was the starting point for this CL: http://pastebin.com/PPhPTtRK

BUG=646685
==========

[maxbogue, 2016-09-30 20:40:45]

The CQ bit was checked by maxbogue@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 20:41:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brettw, 2016-09-30 20:52:42]

non-components lgtm

[commit-bot: I haz the power, 2016-09-30 21:42:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 21:42:38]

Dry run: This issue passed the CQ dry run.

[maxbogue, 2016-09-30 22:03:09]

maxbogue@chromium.org changed reviewers:
+ caitkp@chromium.org

[maxbogue, 2016-09-30 22:03:11]

TBR caitkp@ for the non-sync components.

[maxbogue, 2016-09-30 22:03:34]

Description was changed from

==========
[Sync] Move //components/sync to the syncer namespace.

Things in components should live in namespaces that match their
component. Unfortunately "sync" is a symbol defined in the std library,
so in this case we are using "syncer".

This CL does the following things inside //components/sync:

- Replaces all uses of syncer_v2, sync_driver, sync_driver_v2, and browser_sync
with syncer.
- Adds syncer namespace to some classes that were missing a namespace.
- Removes almost all "syncer::" prefixes since they became redundant.

Everything outside the component is just fixing namespace prefixes and forward
declarations.
I also fixed *some* lints, especially in headers outside of the component.

This script was the starting point for this CL: http://pastebin.com/PPhPTtRK

BUG=646685
==========

to

==========
[Sync] Move //components/sync to the syncer namespace.

Things in components should live in namespaces that match their
component. Unfortunately "sync" is a symbol defined in the std library,
so in this case we are using "syncer".

This CL does the following things inside //components/sync:

- Replaces all uses of syncer_v2, sync_driver, sync_driver_v2, and browser_sync
with syncer.
- Adds syncer namespace to some classes that were missing a namespace.
- Removes almost all "syncer::" prefixes since they became redundant.

Everything outside the component is just fixing namespace prefixes and forward
declarations.
I also fixed *some* lints, especially in headers outside of the component.

This script was the starting point for this CL: http://pastebin.com/PPhPTtRK

BUG=646685
TBR= caitkp
==========

[maxbogue, 2016-09-30 22:03:38]

Description was changed from

==========
[Sync] Move //components/sync to the syncer namespace.

Things in components should live in namespaces that match their
component. Unfortunately "sync" is a symbol defined in the std library,
so in this case we are using "syncer".

This CL does the following things inside //components/sync:

- Replaces all uses of syncer_v2, sync_driver, sync_driver_v2, and browser_sync
with syncer.
- Adds syncer namespace to some classes that were missing a namespace.
- Removes almost all "syncer::" prefixes since they became redundant.

Everything outside the component is just fixing namespace prefixes and forward
declarations.
I also fixed *some* lints, especially in headers outside of the component.

This script was the starting point for this CL: http://pastebin.com/PPhPTtRK

BUG=646685
TBR= caitkp
==========

to

==========
[Sync] Move //components/sync to the syncer namespace.

Things in components should live in namespaces that match their
component. Unfortunately "sync" is a symbol defined in the std library,
so in this case we are using "syncer".

This CL does the following things inside //components/sync:

- Replaces all uses of syncer_v2, sync_driver, sync_driver_v2, and browser_sync
with syncer.
- Adds syncer namespace to some classes that were missing a namespace.
- Removes almost all "syncer::" prefixes since they became redundant.

Everything outside the component is just fixing namespace prefixes and forward
declarations.
I also fixed *some* lints, especially in headers outside of the component.

This script was the starting point for this CL: http://pastebin.com/PPhPTtRK

BUG=646685
TBR=caitkp
==========

[maxbogue, 2016-09-30 22:04:00]

The CQ bit was checked by maxbogue@chromium.org

[maxbogue, 2016-09-30 22:04:02]

The patchset sent to the CQ was uploaded after l-g-t-m from skym@chromium.org
Link to the patchset: https://codereview.chromium.org/2376123003/#ps40001
(title: "Rebase.")

[commit-bot: I haz the power, 2016-09-30 22:04:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 22:24:06]

Description was changed from

==========
[Sync] Move //components/sync to the syncer namespace.

Things in components should live in namespaces that match their
component. Unfortunately "sync" is a symbol defined in the std library,
so in this case we are using "syncer".

This CL does the following things inside //components/sync:

- Replaces all uses of syncer_v2, sync_driver, sync_driver_v2, and browser_sync
with syncer.
- Adds syncer namespace to some classes that were missing a namespace.
- Removes almost all "syncer::" prefixes since they became redundant.

Everything outside the component is just fixing namespace prefixes and forward
declarations.
I also fixed *some* lints, especially in headers outside of the component.

This script was the starting point for this CL: http://pastebin.com/PPhPTtRK

BUG=646685
TBR=caitkp
==========

to

==========
[Sync] Move //components/sync to the syncer namespace.

Things in components should live in namespaces that match their
component. Unfortunately "sync" is a symbol defined in the std library,
so in this case we are using "syncer".

This CL does the following things inside //components/sync:

- Replaces all uses of syncer_v2, sync_driver, sync_driver_v2, and browser_sync
with syncer.
- Adds syncer namespace to some classes that were missing a namespace.
- Removes almost all "syncer::" prefixes since they became redundant.

Everything outside the component is just fixing namespace prefixes and forward
declarations.
I also fixed *some* lints, especially in headers outside of the component.

This script was the starting point for this CL: http://pastebin.com/PPhPTtRK

BUG=646685
TBR=caitkp
==========

[commit-bot: I haz the power, 2016-09-30 22:24:12]

Committed patchset #5 (id:40001)

[commit-bot: I haz the power, 2016-09-30 22:25:54]

Description was changed from

==========
[Sync] Move //components/sync to the syncer namespace.

Things in components should live in namespaces that match their
component. Unfortunately "sync" is a symbol defined in the std library,
so in this case we are using "syncer".

This CL does the following things inside //components/sync:

- Replaces all uses of syncer_v2, sync_driver, sync_driver_v2, and browser_sync
with syncer.
- Adds syncer namespace to some classes that were missing a namespace.
- Removes almost all "syncer::" prefixes since they became redundant.

Everything outside the component is just fixing namespace prefixes and forward
declarations.
I also fixed *some* lints, especially in headers outside of the component.

This script was the starting point for this CL: http://pastebin.com/PPhPTtRK

BUG=646685
TBR=caitkp
==========

to

==========
[Sync] Move //components/sync to the syncer namespace.

Things in components should live in namespaces that match their
component. Unfortunately "sync" is a symbol defined in the std library,
so in this case we are using "syncer".

This CL does the following things inside //components/sync:

- Replaces all uses of syncer_v2, sync_driver, sync_driver_v2, and browser_sync
with syncer.
- Adds syncer namespace to some classes that were missing a namespace.
- Removes almost all "syncer::" prefixes since they became redundant.

Everything outside the component is just fixing namespace prefixes and forward
declarations.
I also fixed *some* lints, especially in headers outside of the component.

This script was the starting point for this CL: http://pastebin.com/PPhPTtRK

BUG=646685
TBR=caitkp

Committed: https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a
Cr-Commit-Position: refs/heads/master@{#422239}
==========

[commit-bot: I haz the power, 2016-09-30 22:25:58]

Patchset 5 (id:??) landed as
https://crrev.com/a1a854356c262a2e501dc3f30ea93585f1c8635a
Cr-Commit-Position: refs/heads/master@{#422239}

[Kunihiko Sakamoto, 2016-10-03 02:36:27]

Let me speculatively revert this to see if it fixes https://crbug.com/652136.