[Sync] Move //components/sync to the syncer namespace.

components/sync/engine_impl/syncer_proto_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/sync/engine_impl/syncer_proto_util.h"
 
 #include <map>
 
 #include "base/format_macros.h"
 #include "base/strings/stringprintf.h"
@@ skipping 11 matching lines @@
 #include "components/sync/syncable/syncable_proto_util.h"
 #include "google_apis/google_api_keys.h"
 
 using std::string;
 using std::stringstream;
 using sync_pb::ClientToServerMessage;
 using sync_pb::ClientToServerResponse;
 
 namespace syncer {
 
-using syncable::BASE_VERSION;
-using syncable::CTIME;
-using syncable::ID;
-using syncable::IS_DEL;
-using syncable::IS_DIR;
-using syncable::IS_UNSYNCED;
-using syncable::MTIME;
-using syncable::PARENT_ID;
+using syncer::syncable::BASE_VERSION;

[skym, 2016/09/30 19:03:22]

Is this really needed? Seems like you shouldn't have to, since you're already in
the syncer namespace.

[maxbogue, 2016/09/30 20:13:41]

Done, here and in another 20ish files where I messed it up.

+using syncer::syncable::CTIME;
+using syncer::syncable::ID;
+using syncer::syncable::IS_DEL;
+using syncer::syncable::IS_DIR;
+using syncer::syncable::IS_UNSYNCED;
+using syncer::syncable::MTIME;
+using syncer::syncable::PARENT_ID;
 
 namespace {
 
 // Time to backoff syncing after receiving a throttled response.
 const int kSyncDelayAfterThrottled = 2 * 60 * 60;  // 2 hours
 
 void LogResponseProfilingData(const ClientToServerResponse& response) {
   if (response.has_profiling_data()) {
     stringstream response_trace;
     response_trace << "Server response trace:";
@@ skipping 542 matching lines @@
 std::string SyncerProtoUtil::ClientToServerResponseDebugString(
     const ClientToServerResponse& response) {
   // Add more handlers as needed.
   std::string output;
   if (response.has_get_updates())
     output.append(GetUpdatesResponseString(response.get_updates()));
   return output;
 }
 
 }  // namespace syncer