Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: scripts/slave/recipe_modules/goma/api.py

Issue 2375843005: Stop redirect stdout/stderr and remove close_fds=True (Closed)
Patch Set: use raw_io for file Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/goma/example.expected/linux.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/goma/api.py
diff --git a/scripts/slave/recipe_modules/goma/api.py b/scripts/slave/recipe_modules/goma/api.py
index 7844de454e2328f47d9a0027cc5423b5d8a092ea..4996ae6dde4d39ad837abbfd30d1aabcae27a4c7 100644
--- a/scripts/slave/recipe_modules/goma/api.py
+++ b/scripts/slave/recipe_modules/goma/api.py
@@ -139,14 +139,13 @@ print jobs
name='start cloudtail',
script=self.resource('cloudtail_utils.py'),
args=['start',
- '--cloudtail-path', self.cloudtail_path],
+ '--cloudtail-path', self.cloudtail_path,
+ '--pid-file', self.m.raw_io.output(name='pid')],
ukai 2016/09/29 07:26:09 use leak_to and reuse it in stop_cloudtail ?
tikuta 2016/09/29 07:46:15 Done.
env=self._goma_ctl_env,
- stdout=self.m.raw_io.output(),
step_test_data=(
- lambda: self.m.raw_io.test_api.stream_output('12345')),
+ lambda: self.m.raw_io.test_api.output('12345', name='pid')),
infra_step=True)
-
- self._cloudtail_pid = step_result.stdout
+ self._cloudtail_pid = step_result.raw_io.outputs['pid']
def _stop_cloudtail(self):
"""Stop cloudtail started by _start_cloudtail
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/goma/example.expected/linux.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698