Stop redirect stdout/stderr and remove close_fds=True

scripts/slave/recipe_modules/goma/api.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from contextlib import contextmanager
 
 from recipe_engine import recipe_api
 
 class GomaApi(recipe_api.RecipeApi):
   """GomaApi contains helper functions for using goma."""
@@ skipping 121 matching lines @@
     Raises:
       InfraFailure if it fails to start cloudtail
     """
 
     assert self._cloudtail_pid is None
 
     step_result = self.m.python(
       name='start cloudtail',
       script=self.resource('cloudtail_utils.py'),
       args=['start',
-            '--cloudtail-path', self.cloudtail_path],
+            '--cloudtail-path', self.cloudtail_path,
+            '--pid-file', self.m.raw_io.output(name='pid')],

[ukai, 2016/09/29 07:26:09]

use leak_to and reuse it in stop_cloudtail ?

[tikuta, 2016/09/29 07:46:15]

Done.

       env=self._goma_ctl_env,
-      stdout=self.m.raw_io.output(),
       step_test_data=(
-          lambda: self.m.raw_io.test_api.stream_output('12345')),
+          lambda: self.m.raw_io.test_api.output('12345', name='pid')),
       infra_step=True)
-
-    self._cloudtail_pid = step_result.stdout
+    self._cloudtail_pid = step_result.raw_io.outputs['pid']
 
   def _stop_cloudtail(self):
     """Stop cloudtail started by _start_cloudtail
 
     Raises:
       InfraFailure if it fails to stop cloudtail
     """
 
     assert self._cloudtail_pid is not None
 
@@ skipping 165 matching lines @@
       ninja_log_exit_status = e.retcode
       raise e
     except self.m.step.InfraFailure as e: # pragma: no cover
       ninja_log_exit_status = -1
       raise e
     finally:
       self.stop(ninja_log_outdir=ninja_log_outdir,
                 ninja_log_compiler=ninja_log_compiler,
                 ninja_log_command=ninja_log_command,
                 ninja_log_exit_status=ninja_log_exit_status)