sdk/lib/_internal/compiler/implementation/js_emitter/type_test_emitter.dart - Issue 237583014: JS templates

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/js_emitter/type_test_emitter.dart

Issue 237583014: JS templates (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: cleanup Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sdk/lib/_internal/compiler/implementation/js_emitter/nsm_emitter.dart ('K') | « sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart ('k') | sdk/lib/_internal/compiler/implementation/native_handler.dart » ('j') | sdk/lib/_internal/compiler/implementation/ssa/builder.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/js_emitter/type_test_emitter.dart

diff --git a/sdk/lib/_internal/compiler/implementation/js_emitter/type_test_emitter.dart b/sdk/lib/_internal/compiler/implementation/js_emitter/type_test_emitter.dart

index f1a67f0418f2023d60af6907a4576fe3c138e5dc..c2cb16be184f734ce89383a9af869eff74fd08e8 100644

--- a/sdk/lib/_internal/compiler/implementation/js_emitter/type_test_emitter.dart

+++ b/sdk/lib/_internal/compiler/implementation/js_emitter/type_test_emitter.dart

@@ -64,7 +64,7 @@ class TypeTestEmitter extends CodeEmitterHelper {

closureData.freeVariableMapping[closureData.thisElement];

if (thisElement != null) {

String thisName = namer.instanceFieldPropertyName(thisElement);

- thisAccess = js('this')[js.string(thisName)];

+ thisAccess = js('this.#', thisName);

}

RuntimeTypes rti = backend.rti;