Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Unified Diff: sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart

Issue 237583014: JS templates (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: cleanup Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart
diff --git a/sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart b/sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart
index 59eb43e75935f982ffe07faf74b0524f93303dec..5509430c764786a6bd6e74a5bbc4716f3dc73677 100644
--- a/sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart
+++ b/sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart
@@ -17,13 +17,6 @@ const bool VALIDATE_DATA = false;
// TODO(ahe): This code should be integrated in CodeEmitterTask.finishClasses.
jsAst.Expression getReflectionDataParser(String classesCollector,
JavaScriptBackend backend) {
- var text = getReflectionDataParserAsString(classesCollector, backend);
- return js(text);
-}
-
-
-String getReflectionDataParserAsString(String classesCollector,
- JavaScriptBackend backend) {
Namer namer = backend.namer;
Compiler compiler = backend.compiler;
Element closureFromTearOff = compiler.findHelper('closureFromTearOff');
@@ -63,7 +56,7 @@ String getReflectionDataParserAsString(String classesCollector,
(function (reflectionData) {
"use strict";
-// [map] returns an object literal that V8 shouldn't try to optimize with a
+// [map] returns an object literal that V8 shouldn not try to optimize with a
// hidden class. This prevents a potential performance problem where V8 tries
// to build a hidden class for an object used as a hashMap.
@@ -321,7 +314,7 @@ String footer = '''
})
''';
- return '$header$processStatics$addStubs$tearOff$init$footer';
+ return js('$header$processStatics$addStubs$tearOff$init$footer');
}
String readString(String array, String index) {

Powered by Google App Engine
This is Rietveld 408576698